Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 2859763003: Fixing DCHECK in turnport.cc that was broken by refactoring. (Closed)

Created:
3 years, 7 months ago by Taylor Brandstetter
Modified:
3 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing DCHECK in turnport.cc that was broken by refactoring. "PROTO_TCP + secure bit" was turned into "PROTO_TLS" by this CL: https://codereview.webrtc.org/2568833002 But a "DCHECK(proto == PROTO_TCP)" wasn't updated to take this into account. BUG=NONE TBR=pthatcher@webrtc.org Review-Url: https://codereview.webrtc.org/2859763003 Cr-Commit-Position: refs/heads/master@{#18000} Committed: https://chromium.googlesource.com/external/webrtc/+/bbe2a370f79dc868302759430b5e122b5e6953a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M webrtc/p2p/base/turnport.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Taylor Brandstetter
PTAL
3 years, 7 months ago (2017-05-03 16:30:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2859763003/1
3 years, 7 months ago (2017-05-03 16:30:36 UTC) #3
Taylor Brandstetter
This somewhat worries me, because I guess it means we have no tests that exercise ...
3 years, 7 months ago (2017-05-03 16:32:17 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 16:48:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/bbe2a370f79dc868302759430...

Powered by Google App Engine
This is Rietveld 408576698