Refactor "secure bool" into explicit PROTO_TLS.

Refactor "secure bool" into explicit PROTO_TLS.

BUG=none

Committed: https://crrev.com/277b25093660ea7cd4ac5f849b91f7f18cbd6220
Cr-Commit-Position: refs/heads/master@{#15572}

[hnsl1, 2016-12-12 16:08:09]

hnsl@webrtc.org changed reviewers:
+ deadbeef@webrtc.org, pthatcher@webrtc.org

[hnsl1, 2016-12-12 16:08:10]

Please review this refactor CL.

It is partially forked out of https://codereview.webrtc.org/2557803002

[hnsl1, 2016-12-12 16:10:18]

The CQ bit was checked by hnsl@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 16:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-12 16:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:27:56]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2016-12-12 17:35:49]

lgtm

[Taylor Brandstetter, 2016-12-13 00:31:40]

lgtm

https://codereview.webrtc.org/2568833002/diff/1/webrtc/p2p/base/turnport.cc
File webrtc/p2p/base/turnport.cc (right):

https://codereview.webrtc.org/2568833002/diff/1/webrtc/p2p/base/turnport.cc#n...
webrtc/p2p/base/turnport.cc:53: default:
nit: I'd RTC_DCHECK that proto is PROTO_UDP, in case we add something else
later.

[hnsl1, 2016-12-13 12:53:02]

https://codereview.webrtc.org/2568833002/diff/1/webrtc/p2p/base/turnport.cc
File webrtc/p2p/base/turnport.cc (right):

https://codereview.webrtc.org/2568833002/diff/1/webrtc/p2p/base/turnport.cc#n...
webrtc/p2p/base/turnport.cc:53: default:
On 2016/12/13 00:31:40, Taylor Brandstetter wrote:
> nit: I'd RTC_DCHECK that proto is PROTO_UDP, in case we add something else
> later.

Done.

[hnsl1, 2016-12-13 12:53:10]

The CQ bit was checked by hnsl@webrtc.org

[hnsl1, 2016-12-13 12:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2568833002/#ps20001 (title:
"GetRelayPreference(): Add RTC_DCHECK(proto == PROTO_UDP).")

[commit-bot: I haz the power, 2016-12-13 12:53:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-12-13 13:17:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481633590477650,
"parent_rev": "d0cfc9495ef98ab32f81f9e46d1d29027295ebed", "commit_rev":
"d9a328b1a4a35e954875664dc94e07384776bb34"}

[commit-bot: I haz the power, 2016-12-13 13:17:26]

Description was changed from

==========
Refactor "secure bool" into explicit PROTO_TLS.

BUG=none
==========

to

==========
Refactor "secure bool" into explicit PROTO_TLS.

BUG=none

Review-Url: https://codereview.webrtc.org/2568833002
==========

[commit-bot: I haz the power, 2016-12-13 13:17:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 13:17:35]

Description was changed from

==========
Refactor "secure bool" into explicit PROTO_TLS.

BUG=none

Review-Url: https://codereview.webrtc.org/2568833002
==========

to

==========
Refactor "secure bool" into explicit PROTO_TLS.

BUG=none

Committed: https://crrev.com/277b25093660ea7cd4ac5f849b91f7f18cbd6220
Cr-Commit-Position: refs/heads/master@{#15572}
==========

[commit-bot: I haz the power, 2016-12-13 13:17:36]

Patchset 2 (id:??) landed as
https://crrev.com/277b25093660ea7cd4ac5f849b91f7f18cbd6220
Cr-Commit-Position: refs/heads/master@{#15572}