Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: webrtc/p2p/base/turnport.cc

Issue 2859763003: Fixing DCHECK in turnport.cc that was broken by refactoring. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/turnport.cc
diff --git a/webrtc/p2p/base/turnport.cc b/webrtc/p2p/base/turnport.cc
index 56dadde9bb1521845bfad4e43dc5e7bce5370c4f..e3caeb59d3e6b43c93310f10f25866aa45f47eea 100644
--- a/webrtc/p2p/base/turnport.cc
+++ b/webrtc/p2p/base/turnport.cc
@@ -376,7 +376,11 @@ bool TurnPort::CreateTurnClientSocket() {
}
void TurnPort::OnSocketConnect(rtc::AsyncPacketSocket* socket) {
- RTC_DCHECK(server_address_.proto == PROTO_TCP);
+ // This slot should only be invoked if we're using a connection-oriented
+ // protocol.
+ RTC_DCHECK(server_address_.proto == PROTO_TCP ||
+ server_address_.proto == PROTO_TLS);
+
// Do not use this port if the socket bound to a different address than
// the one we asked for. This is seen in Chrome, where TCP sockets cannot be
// given a binding address, and the platform is expected to pick the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698