Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2852663002: Reland of Enable GN check for webrtc/base (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Enable GN check for webrtc/base (patchset #3 id:230001 of https://codereview.webrtc.org/2838683002/ ) Reason for revert: Fourth attempt to land. Waiting for https://codereview.webrtc.org/2845013003 to avoid conflicts on webrtc/modules/audio_coding:neteq_unittest_tools. Original issue's description: > Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) > > Reason for revert: > Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). > > Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. > > Original issue's description: > > Enable GN check for webrtc/base > > > > It's not possible to enable it for the rtc_base_approved > > target but since a larger refactoring is ongoing for webrtc/base > > this CL doesn't attempt to fix that. > > > > Changes made: > > * Move webrtc/system_wrappers/include/stringize_macros.h into > > webrtc/base:rtc_base_approved_unittests (and corresponding > > unit test to rtc_base_approved_unittests). > > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > > webrtc/base. > > * Remove unused use include of webrtc/base/fileutils.h in > > webrtc/base/pathutils.cc > > > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2717083002 > > Cr-Commit-Position: refs/heads/master@{#17766} > > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac > > TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838683002 > Cr-Commit-Position: refs/heads/master@{#17849} > Committed: https://chromium.googlesource.com/external/webrtc/+/11ed366c487a938815cd52ad2ab5467b0f90e1ae TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 Review-Url: https://codereview.webrtc.org/2852663002 Cr-Commit-Position: refs/heads/master@{#17927} Committed: https://chromium.googlesource.com/external/webrtc/+/148d5a2dcaa54bfaa1fd1ce77eb57a399bf04557

Patch Set 1 #

Patch Set 2 : moving rtc_base_tests_utils out of rtc_include_tests #

Patch Set 3 : running chromium trybots #

Patch Set 4 : removing gflags from test_support deps #

Total comments: 2

Patch Set 5 : avoiding to pull rtc_sdk_common_objc in chromium #

Patch Set 6 : removing chromium problematic deps from test group #

Patch Set 7 : moving test_common in problematic chromium deps #

Patch Set 8 : avoid to pull video_capture_internal_impl in chromium #

Patch Set 9 : fixing yet another dep problem #

Patch Set 10 : re-enabling gn check after chromium trybots #

Patch Set 11 : fixing compile error #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -199 lines) Patch
M .gn View 1 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 10 chunks +86 lines, -62 lines 0 comments Download
M webrtc/base/location.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/base/pathutils.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + webrtc/base/stringize_macros.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/base/stringize_macros_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/system_wrappers/include/stringize_macros.h View 1 chunk +0 lines, -38 lines 0 comments Download
D webrtc/system_wrappers/source/stringize_macros_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 5 chunks +72 lines, -55 lines 3 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
mbonadei
Created Reland of Enable GN check for webrtc/base
3 years, 7 months ago (2017-04-28 06:41:04 UTC) #1
kjellander_webrtc
https://codereview.webrtc.org/2852663002/diff/110003/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2852663002/diff/110003/webrtc/test/BUILD.gn#newcode158 webrtc/test/BUILD.gn:158: deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ] You need to change ...
3 years, 7 months ago (2017-04-28 08:56:48 UTC) #2
mbonadei
https://codereview.webrtc.org/2852663002/diff/110003/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2852663002/diff/110003/webrtc/test/BUILD.gn#newcode158 webrtc/test/BUILD.gn:158: deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ] On 2017/04/28 08:56:48, kjellander_webrtc ...
3 years, 7 months ago (2017-04-28 09:05:57 UTC) #3
mbonadei
It looks like we are close. PTAL. As we discovered yesterday in https://codereview.webrtc.org/2846803002/ the file ...
3 years, 7 months ago (2017-04-28 10:14:06 UTC) #4
kjellander_webrtc
lgtm https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn#newcode142 webrtc/test/BUILD.gn:142: if (is_ios && !build_with_chromium) { Actually, for the ...
3 years, 7 months ago (2017-04-28 11:52:24 UTC) #5
mbonadei
https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn#newcode142 webrtc/test/BUILD.gn:142: if (is_ios && !build_with_chromium) { On 2017/04/28 11:52:24, kjellander_webrtc ...
3 years, 7 months ago (2017-04-28 11:54:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2852663002/380001
3 years, 7 months ago (2017-04-28 11:54:55 UTC) #8
kjellander_webrtc
https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn File webrtc/test/BUILD.gn (right): https://codereview.webrtc.org/2852663002/diff/380001/webrtc/test/BUILD.gn#newcode142 webrtc/test/BUILD.gn:142: if (is_ios && !build_with_chromium) { On 2017/04/28 11:54:33, mbonadei ...
3 years, 7 months ago (2017-04-28 12:24:49 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 12:24:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #11 (id:380001) as
https://chromium.googlesource.com/external/webrtc/+/148d5a2dcaa54bfaa1fd1ce77...

Powered by Google App Engine
This is Rietveld 408576698