Reland of Enable GN check for webrtc/base

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 import("//build/config/ui.gni")
@@ skipping 98 matching lines @@
 if (is_ios) {
   bundle_data("test_support_unittests_bundle_data") {
     testonly = true
     sources = test_support_unittests_resources
     outputs = [
       "{{bundle_resources_dir}}/{{source_file_part}}",
     ]
   }
 }
 
+rtc_source_set("test_support") {
+  testonly = true
+
+  sources = [
+    "gmock.h",
+    "gtest.h",
+    "testsupport/packet_reader.cc",
+    "testsupport/packet_reader.h",
+    "testsupport/perf_test.cc",
+    "testsupport/perf_test.h",
+    "testsupport/trace_to_stderr.cc",
+    "testsupport/trace_to_stderr.h",
+    "testsupport/unittest_utils.h",
+  ]
+
+  deps = [
+    "..:webrtc_common",
+    "../base:gtest_prod",
+    "../base:rtc_base_approved",
+    "../common_video",
+    "../system_wrappers",
+    "//testing/gmock",
+    "//testing/gtest",
+  ]
+
+  public_deps = [
+    ":fileutils",
+  ]
+
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+
+  if (is_android) {
+    deps += [ "//base:base" ]
+  }
+
+  if (is_ios) {
+    deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]

[kjellander_webrtc, 2017/04/28 08:56:48]

You need to change this to be a relative path now, that it will be loaded from a
Chromium context (it didn't use to).

I'm starting to get concerned about the amount of objects we'll be adding to the
Chromium build with this though, so I think it's better to avoid this by adding
!build_with_chromium in addition to the is_ios condition.

[mbonadei, 2017/04/28 09:05:57]

Thanks!

+  }
+
+  if (rtc_use_memcheck) {
+    data = valgrind_webrtc_dependencies
+  }
+}
+
 if (!build_with_chromium) {
   # This target depends on //third_party/gflags and since chromium does not
   # have gflags it causes an error when Gn parses this BUILD.gn file.
   # It seems that Gn eagerly tries to understand if all the targets are
   # buildable (even deps). Obviously gflags is not buildable in chromium
   # so if a target depends on this BUILD.gn file we hit this error.
   rtc_source_set("test_main") {
     testonly = true
     sources = [
       "test_main.cc",
@@ skipping 50 matching lines @@
 
     if (is_ios) {
       deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]
     }
 
     if (rtc_use_memcheck) {
       data = valgrind_webrtc_dependencies
     }
   }
 
-  rtc_source_set("test_support") {
+  rtc_source_set("test_support_isolated_output") {
     testonly = true
-
     sources = [
-      "gmock.h",
-      "gtest.h",
       "testsupport/isolated_output.cc",
       "testsupport/isolated_output.h",
-      "testsupport/packet_reader.cc",
-      "testsupport/packet_reader.h",
-      "testsupport/perf_test.cc",
-      "testsupport/perf_test.h",
-      "testsupport/trace_to_stderr.cc",
-      "testsupport/trace_to_stderr.h",
-      "testsupport/unittest_utils.h",
     ]
-
     deps = [
-      "../base:gtest_prod",
+      ":fileutils",
       "../base:rtc_base_approved",
-      "../common_video",
-      "../system_wrappers",
-      "//testing/gmock",
-      "//testing/gtest",
       "//third_party/gflags",
     ]
-
-    public_deps = [
-      ":fileutils",
-    ]
-
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-
-    if (is_android) {
-      deps += [ "//base:base" ]
-    }
-
-    if (is_ios) {
-      deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]
-    }
-
-    if (rtc_use_memcheck) {
-      data = valgrind_webrtc_dependencies
-    }
   }
 
   rtc_test("test_support_unittests") {
     deps = []
     sources = [
       "fake_audio_device_unittest.cc",
       "fake_network_pipe_unittest.cc",
       "frame_generator_unittest.cc",
       "rtp_file_reader_unittest.cc",
       "rtp_file_writer_unittest.cc",
@@ skipping 254 matching lines @@
   ]
 }
 
 rtc_source_set("audio_codec_mocks") {
   testonly = true
   sources = [
     "mock_audio_decoder.h",
     "mock_audio_decoder_factory.h",
   ]
 }