Reland of Enable GN check for webrtc/base

webrtc/test/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 import("//build/config/ui.gni")
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 if (rtc_use_memcheck) {
   import("//tools-webrtc/valgrind/valgrind-webrtc.gni")
 }
 
 group("test") {
   testonly = true
 
   deps = [
     ":field_trial",
     ":rtp_test_utils",
     ":test_common",
-    ":test_main",
     ":test_renderer",
     ":test_support",
-    ":test_support_unittests",
     ":video_test_common",
   ]
+
+  if (!build_with_chromium) {
+    deps += [
+      ":test_main",
+      ":test_support_unittests",
+    ]
+  }
 }
 
 rtc_source_set("video_test_common") {
   testonly = true
   sources = [
     "fake_texture_frame.cc",
     "fake_texture_frame.h",
     "frame_generator.cc",
     "frame_generator.h",
     "frame_generator_capturer.cc",
@@ skipping 48 matching lines @@
     "field_trial.h",
   ]
 
   deps = [
     "..:webrtc_common",
     "../system_wrappers",
     "../system_wrappers:field_trial_default",
   ]
 }
 
-test_support_unittests_resources = [
-  "//resources/foreman_cif_short.yuv",
-  "//resources/video_coding/frame-ethernet-ii.pcap",
-  "//resources/video_coding/frame-loopback.pcap",
-  "//resources/video_coding/pltype103.rtp",
-  "//resources/video_coding/pltype103_header_only.rtp",
-  "//resources/video_coding/ssrcs-2.pcap",
-  "//resources/video_coding/ssrcs-3.pcap",
-]
+rtc_source_set("test_support") {
+  testonly = true
 
-if (is_ios) {
-  bundle_data("test_support_unittests_bundle_data") {
-    testonly = true
-    sources = test_support_unittests_resources
-    outputs = [
-      "{{bundle_resources_dir}}/{{source_file_part}}",
-    ]
+  sources = [
+    "gmock.h",
+    "gtest.h",
+    "testsupport/packet_reader.cc",
+    "testsupport/packet_reader.h",
+    "testsupport/perf_test.cc",
+    "testsupport/perf_test.h",
+    "testsupport/trace_to_stderr.cc",
+    "testsupport/trace_to_stderr.h",
+    "testsupport/unittest_utils.h",
+  ]
+
+  deps = [
+    "..:webrtc_common",
+    "../base:gtest_prod",
+    "../base:rtc_base_approved",
+    "../common_video",
+    "../system_wrappers",
+    "//testing/gmock",
+    "//testing/gtest",
+  ]
+
+  public_deps = [
+    ":fileutils",
+  ]
+
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+
+  if (is_android) {
+    deps += [ "//base:base" ]
+  }
+
+  if (is_ios && !build_with_chromium) {

[kjellander_webrtc, 2017/04/28 11:52:24]

Actually, for the WebRTC build, this dependency should be moved to the
:fileutils target since that's where it's used (from
testsupport/iosfileutils.mm). 
I tried compiling with it moved and it passed as expected. Can you move it? Can
be done in a follow-up CL though, no need to block this.

[mbonadei, 2017/04/28 11:54:33]

Ok, I land this right away because I would like to avoid to run the trybots
again. I will open a CL in a few minutes.

[kjellander_webrtc, 2017/04/28 12:24:49]

After https://codereview.webrtc.org/2849823002/ we can let this remain a part of
test_support target, since it's only one object being pulled in. I'll let you
land first though, and rebase mine.

+    deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]
+  }
+
+  if (rtc_use_memcheck) {
+    data = valgrind_webrtc_dependencies
   }
 }
 
 if (!build_with_chromium) {
   # This target depends on //third_party/gflags and since chromium does not
   # have gflags it causes an error when Gn parses this BUILD.gn file.
   # It seems that Gn eagerly tries to understand if all the targets are
   # buildable (even deps). Obviously gflags is not buildable in chromium
   # so if a target depends on this BUILD.gn file we hit this error.
   rtc_source_set("test_main") {
@@ skipping 53 matching lines @@
 
     if (is_ios) {
       deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]
     }
 
     if (rtc_use_memcheck) {
       data = valgrind_webrtc_dependencies
     }
   }
 
-  rtc_source_set("test_support") {
+  rtc_source_set("test_support_isolated_output") {
     testonly = true
-
     sources = [
-      "gmock.h",
-      "gtest.h",
       "testsupport/isolated_output.cc",
       "testsupport/isolated_output.h",
-      "testsupport/packet_reader.cc",
-      "testsupport/packet_reader.h",
-      "testsupport/perf_test.cc",
-      "testsupport/perf_test.h",
-      "testsupport/trace_to_stderr.cc",
-      "testsupport/trace_to_stderr.h",
-      "testsupport/unittest_utils.h",
     ]
-
     deps = [
-      "../base:gtest_prod",
+      ":fileutils",
       "../base:rtc_base_approved",
-      "../common_video",
-      "../system_wrappers",
-      "//testing/gmock",
-      "//testing/gtest",
       "//third_party/gflags",
     ]
+  }
 
-    public_deps = [
-      ":fileutils",
-    ]
+  test_support_unittests_resources = [
+    "//resources/foreman_cif_short.yuv",
+    "//resources/video_coding/frame-ethernet-ii.pcap",
+    "//resources/video_coding/frame-loopback.pcap",
+    "//resources/video_coding/pltype103.rtp",
+    "//resources/video_coding/pltype103_header_only.rtp",
+    "//resources/video_coding/ssrcs-2.pcap",
+    "//resources/video_coding/ssrcs-3.pcap",
+  ]
 
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
-
-    if (is_android) {
-      deps += [ "//base:base" ]
-    }
-
-    if (is_ios) {
-      deps += [ "//webrtc/sdk:rtc_sdk_common_objc" ]
-    }
-
-    if (rtc_use_memcheck) {
-      data = valgrind_webrtc_dependencies
+  if (is_ios) {
+    bundle_data("test_support_unittests_bundle_data") {
+      testonly = true
+      sources = test_support_unittests_resources
+      outputs = [
+        "{{bundle_resources_dir}}/{{source_file_part}}",
+      ]
     }
   }
 
   rtc_test("test_support_unittests") {
     deps = []
     sources = [
       "fake_audio_device_unittest.cc",
       "fake_network_pipe_unittest.cc",
       "frame_generator_unittest.cc",
       "rtp_file_reader_unittest.cc",
@@ skipping 29 matching lines @@
 
     if (is_ios) {
       deps += [ ":test_support_unittests_bundle_data" ]
     }
 
     deps += [
       ":direct_transport",
       ":fileutils_unittests",
       ":test_common",
       ":test_main",
+      ":test_support_isolated_output",
       ":video_test_common",
       ":video_test_support",
       "../modules/video_capture",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/gflags",
     ]
   }
 }
 
@@ skipping 122 matching lines @@
     "../audio",
     "../base:rtc_base_approved",
     "../call",
     "../modules/audio_coding:builtin_audio_encoder_factory",
     "../modules/audio_mixer:audio_mixer_impl",
     "../modules/audio_processing",
     "../video",
     "//testing/gmock",
     "//testing/gtest",
   ]
-  if (!is_android) {
+  if (!is_android && !build_with_chromium) {
     deps += [ "../modules/video_capture:video_capture_internal_impl" ]
   }
 }
 
 config("test_renderer_exported_config") {
   if (is_win && is_clang) {
     # GN orders flags on a target before flags from configs. The default config
     # adds -Wall, and this flag have to be after -Wall -- so they need to
     # come from a config and cannot be on the target directly.
     cflags = [
@@ skipping 63 matching lines @@
   ]
 }
 
 rtc_source_set("audio_codec_mocks") {
   testonly = true
   sources = [
     "mock_audio_decoder.h",
     "mock_audio_decoder_factory.h",
   ]
 }