Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2843913002: Reland of Creating webrtc/modules:module_api (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Creating webrtc/modules:module_api (patchset #1 id:1 of https://codereview.webrtc.org/2839963005/ ) Reason for revert: Fixing the Gn error and try to reland. Original issue's description: > Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) > > Reason for revert: > Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio > > Original issue's description: > > Creating webrtc/modules:module_api > > > > This target keeps track of .h the files under webrtc/modules/include/ > > that are not part of any target. > > If a .h file is not part of a target the 'gn check' utility is not > > able to spot if a target is missing a dependency because even if > > it parses '#include' directives it is not able to find a target that > > contains these headers. > > > > BUG=webrtc:7513 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2838873002 > > Cr-Commit-Position: refs/heads/master@{#17880} > > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7513 > > Review-Url: https://codereview.webrtc.org/2839963005 > Cr-Commit-Position: refs/heads/master@{#17881} > Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true TBR=kjellander@webrtc.org BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2843913002 Cr-Commit-Position: refs/heads/master@{#17884} Committed: https://chromium.googlesource.com/external/webrtc/+/1140f97e4827b21212e9d8e622e7708b5bb2e29b

Patch Set 1 #

Patch Set 2 : Fixing syntax error in BUILD.gn file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -4 lines) Patch
M webrtc/api/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/audio/utility/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/BUILD.gn View 1 3 chunks +14 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 1 12 chunks +14 lines, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/BUILD.gn View 1 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 4 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 5 chunks +5 lines, -0 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/tools/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mbonadei
Created Reland of Creating webrtc/modules:module_api
3 years, 8 months ago (2017-04-26 09:01:17 UTC) #1
mbonadei
On 2017/04/26 09:01:17, mbonadei wrote: > Created Reland of Creating webrtc/modules:module_api This is needed because ...
3 years, 8 months ago (2017-04-26 09:04:29 UTC) #2
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-26 09:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2843913002/280001
3 years, 8 months ago (2017-04-26 10:38:28 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 10:38:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:280001) as
https://chromium.googlesource.com/external/webrtc/+/1140f97e4827b21212e9d8e62...

Powered by Google App Engine
This is Rietveld 408576698