Creating webrtc/modules:module_api

Creating webrtc/modules:module_api

This target keeps track of .h the files under webrtc/modules/include/
that are not part of any target.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True

Review-Url: https://codereview.webrtc.org/2838873002
Cr-Commit-Position: refs/heads/master@{#17880}
Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51

[mbonadei, 2017-04-25 12:25:54]

Description was changed from

==========
Creating webrtc/modules:module_api

This target keeps track of the files under webrtc/modules/include.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
==========

to

==========
Creating webrtc/modules:module_api

This target keeps track of the files under webrtc/modules/include.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True
==========

[mbonadei, 2017-04-25 12:40:18]

Description was changed from

==========
Creating webrtc/modules:module_api

This target keeps track of the files under webrtc/modules/include.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True
==========

to

==========
Creating webrtc/modules:module_api

This target keeps track of .h the files under webrtc/modules/include/
that are not part of any target.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True
==========

[mbonadei, 2017-04-25 13:25:52]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-04-25 20:14:41]

lgtm with nit fixed.

I fired the linux_libfuzzer_rel trybot for you (update your alias).

https://codereview.webrtc.org/2838873002/diff/40001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2838873002/diff/40001/webrtc/modules/BUILD.gn#n...
webrtc/modules/BUILD.gn:216: ":module_api",
Move this to line 229

[mbonadei, 2017-04-26 08:11:39]

https://codereview.webrtc.org/2838873002/diff/40001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2838873002/diff/40001/webrtc/modules/BUILD.gn#n...
webrtc/modules/BUILD.gn:216: ":module_api",
On 2017/04/25 20:14:40, kjellander_webrtc wrote:
> Move this to line 229

Done.

[mbonadei, 2017-04-26 08:51:09]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-04-26 08:51:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2838873002/#ps80001 (title:
"fixing gn coding standards")

[commit-bot: I haz the power, 2017-04-26 08:51:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-26 08:53:55]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493196669052190,
"parent_rev": "7866cfe575e85978dba50b1c4a1877a325601fe1", "commit_rev":
"5a1a092ed09ca92719eeb293275f64c0cdcc0e51"}

[commit-bot: I haz the power, 2017-04-26 08:53:58]

Description was changed from

==========
Creating webrtc/modules:module_api

This target keeps track of .h the files under webrtc/modules/include/
that are not part of any target.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True
==========

to

==========
Creating webrtc/modules:module_api

This target keeps track of .h the files under webrtc/modules/include/
that are not part of any target.
If a .h file is not part of a target the 'gn check' utility is not
able to spot if a target is missing a dependency because even if
it parses '#include' directives it is not able to find a target that
contains these headers.

BUG=webrtc:7513
NOTRY=True

Review-Url: https://codereview.webrtc.org/2838873002
Cr-Commit-Position: refs/heads/master@{#17880}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb2932...
==========

[commit-bot: I haz the power, 2017-04-26 08:53:59]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb2932...

[mbonadei, 2017-04-26 09:00:05]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2839963005/ by mbonadei@webrtc.org.

The reason for reverting is: Causes build problem:
https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28....

[kjellander_webrtc, 2017-04-26 09:36:32]

https://codereview.webrtc.org/2838873002/diff/80001/webrtc/modules/BUILD.gn
File webrtc/modules/BUILD.gn (right):

https://codereview.webrtc.org/2838873002/diff/80001/webrtc/modules/BUILD.gn#n...
webrtc/modules/BUILD.gn:225: ":module_api",
Ouch, annoying mistake that reminds us to always run additional tests before
submit even if you made the simplest change.