Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 2839963005: Revert of Creating webrtc/modules:module_api (Closed)

Created:
2 years, 4 months ago by mbonadei
Modified:
2 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Creating webrtc/modules:module_api (patchset #5 id:80001 of https://codereview.webrtc.org/2838873002/ ) Reason for revert: Causes build problem: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Sim%20Debug%20%28iOS%209.0%29/builds/1630/steps/generate%20build%20files%20%28mb%29/logs/stdio Original issue's description: > Creating webrtc/modules:module_api > > This target keeps track of .h the files under webrtc/modules/include/ > that are not part of any target. > If a .h file is not part of a target the 'gn check' utility is not > able to spot if a target is missing a dependency because even if > it parses '#include' directives it is not able to find a target that > contains these headers. > > BUG=webrtc:7513 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2838873002 > Cr-Commit-Position: refs/heads/master@{#17880} > Committed: https://chromium.googlesource.com/external/webrtc/+/5a1a092ed09ca92719eeb293275f64c0cdcc0e51 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7513 Review-Url: https://codereview.webrtc.org/2839963005 Cr-Commit-Position: refs/heads/master@{#17881} Committed: https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -72 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/audio/utility/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/BUILD.gn View 3 chunks +2 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 12 chunks +1 line, -14 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_mixer/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/media_file/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 5 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/video_processing/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 7 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Creating webrtc/modules:module_api
2 years, 4 months ago (2017-04-26 09:00:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2839963005/1
2 years, 4 months ago (2017-04-26 09:00:09 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/bb08c3e29656fafe8a2d5d16ec4a62db49689f8a
2 years, 4 months ago (2017-04-26 09:00:22 UTC) #6
mbonadei
2 years, 4 months ago (2017-04-26 09:01:16 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2843913002/ by mbonadei@webrtc.org.

The reason for reverting is: Fixing the Gn error and try to reland..

Powered by Google App Engine
This is Rietveld 408576698