NetEq: Add functionality to assist with delay analysis and tooling

NetEq: Add functionality to assist with delay analysis and tooling

This CL adds a few methods to the NetEq API that will be used for
delay analysis and plotting.

BUG=webrtc:7467
Review-Url: https://codereview.webrtc.org/2839163002
Cr-Commit-Position: refs/heads/master@{#17889}
Committed: https://chromium.googlesource.com/external/webrtc/+/114c1b3afaced323fdb0a15ce026d9a8d50bb230

[hlundin-webrtc, 2017-04-26 11:41:21]

Description was changed from

==========
NetEq: Add functionality to assist with delay analysis and tooling

This CL adds a few methods to the NetEq API that will be used for
delay analysis and plotting.

BUG=webrtc:7467
==========

to

==========
NetEq: Add functionality to assist with delay analysis and tooling

This CL adds a few methods to the NetEq API that will be used for
delay analysis and plotting.

BUG=webrtc:7467
==========

[hlundin-webrtc, 2017-04-26 11:41:21]

henrik.lundin@webrtc.org changed reviewers:
+ alessiob@webrtc.org, ivoc@webrtc.org

[hlundin-webrtc, 2017-04-26 11:41:21]

henrik.lundin@webrtc.org changed required reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2017-04-26 11:41:31]

Please, take a look.

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_unittest.cc (left):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_unittest.cc:273: rtc::Optional<uint32_t>
PlayoutTimestamp();
This is unrelated, but I deleted this unnecessary helper method. It is no longer
needed after NetEq::GetPlayoutTimestamp() was changed from writing to an output
variable to actually returning an Optional.

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/sync_buffer.h (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/sync_buffer.h:29: // Returns the number of
samples yet to play out from the buffer.
Totally unrelated typo fix.

[ivoc, 2017-04-26 12:23:44]

LGTM with one question.

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:1518:
RTC_DCHECK(last_decoded_timestamps_.empty());
Couldn't this function be called back-to-back without any calls to
GetAudioInternal in between?

[AleBzk, 2017-04-26 13:52:34]

LGTM with two nits

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/include/neteq.h (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/include/neteq.h:315: virtual size_t
SyncBufferSizeMs() const = 0;
Picky question, only relevant if TargetDelayMs() returns non-negative values
only. TargetDelayMs() above returns int, whereas SyncBufferSizeMs() returns
size_t but the unit is ms for both. Is there any preference/recommendation?

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_unittest.cc (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_unittest.cc:1617: // auto
decoded_timestamps = neteq_->LastDecodedTimestamps();
Did you forget to remove the comment above?

[hlundin-webrtc, 2017-04-26 14:11:39]

Thanks for your comments!

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/include/neteq.h (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/include/neteq.h:315: virtual size_t
SyncBufferSizeMs() const = 0;
On 2017/04/26 13:52:34, AleBzk wrote:
> Picky question, only relevant if TargetDelayMs() returns non-negative values
> only. TargetDelayMs() above returns int, whereas SyncBufferSizeMs() returns
> size_t but the unit is ms for both. Is there any preference/recommendation?

int is preferred. I changed it.

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:1518:
RTC_DCHECK(last_decoded_timestamps_.empty());
On 2017/04/26 12:23:43, ivoc wrote:
> Couldn't this function be called back-to-back without any calls to
> GetAudioInternal in between?

I hope not.

NetEqImpl::GetAudioInternal calls NetEqImpl::Decode at most one time.
NetEqImpl::Decode calls NetEqImpl::DecodeLoop at most one time.

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_unittest.cc (right):

https://codereview.webrtc.org/2839163002/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_unittest.cc:1617: // auto
decoded_timestamps = neteq_->LastDecodedTimestamps();
On 2017/04/26 13:52:34, AleBzk wrote:
> Did you forget to remove the comment above?

Ooops! Thanks.

[hlundin-webrtc, 2017-04-26 14:12:13]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2017-04-26 14:12:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ivoc@webrtc.org,
alessiob@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2839163002/#ps20001 (title:
"After first round of reviews")

[commit-bot: I haz the power, 2017-04-26 14:12:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-26 14:47:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493215933215160,
"parent_rev": "2e79958c42154fef56ba165b154f04ec2ca4e705", "commit_rev":
"114c1b3afaced323fdb0a15ce026d9a8d50bb230"}

[commit-bot: I haz the power, 2017-04-26 14:47:37]

Description was changed from

==========
NetEq: Add functionality to assist with delay analysis and tooling

This CL adds a few methods to the NetEq API that will be used for
delay analysis and plotting.

BUG=webrtc:7467
==========

to

==========
NetEq: Add functionality to assist with delay analysis and tooling

This CL adds a few methods to the NetEq API that will be used for
delay analysis and plotting.

BUG=webrtc:7467

Review-Url: https://codereview.webrtc.org/2839163002
Cr-Commit-Position: refs/heads/master@{#17889}
Committed:
https://chromium.googlesource.com/external/webrtc/+/114c1b3afaced323fdb0a15ce...
==========

[commit-bot: I haz the power, 2017-04-26 14:47:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/114c1b3afaced323fdb0a15ce...