Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: webrtc/modules/audio_coding/neteq/include/neteq.h

Issue 2839163002: NetEq: Add functionality to assist with delay analysis and tooling (Closed)
Patch Set: After first round of reviews Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/neteq/neteq_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/include/neteq.h
diff --git a/webrtc/modules/audio_coding/neteq/include/neteq.h b/webrtc/modules/audio_coding/neteq/include/neteq.h
index 322a86fe7c5786241f1a08193d27b5c18b8dc0a2..f03458092eb266d3c383d9c4144bb45cfe436df9 100644
--- a/webrtc/modules/audio_coding/neteq/include/neteq.h
+++ b/webrtc/modules/audio_coding/neteq/include/neteq.h
@@ -14,6 +14,7 @@
#include <string.h> // Provide access to size_t.
#include <string>
+#include <vector>
#include "webrtc/base/constructormagic.h"
#include "webrtc/base/optional.h"
@@ -211,8 +212,9 @@ class NetEq {
// Not implemented.
virtual int SetTargetDelay() = 0;
- // Not implemented.
- virtual int TargetDelay() = 0;
+ // Returns the current target delay in ms. This includes any extra delay
+ // requested through SetMinimumDelay.
+ virtual int TargetDelayMs() = 0;
// Returns the current total delay (packet buffer and sync buffer) in ms.
virtual int CurrentDelayMs() const = 0;
@@ -302,6 +304,16 @@ class NetEq {
virtual std::vector<uint16_t> GetNackList(
int64_t round_trip_time_ms) const = 0;
+ // Returns a vector containing the timestamps of the packets that were decoded
+ // in the last GetAudio call. If no packets were decoded in the last call, the
+ // vector is empty.
+ // Mainly intended for testing.
+ virtual std::vector<uint32_t> LastDecodedTimestamps() const = 0;
+
+ // Returns the length of the audio yet to play in the sync buffer.
+ // Mainly intended for testing.
+ virtual int SyncBufferSizeMs() const = 0;
+
protected:
NetEq() {}
« no previous file with comments | « no previous file | webrtc/modules/audio_coding/neteq/neteq_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698