Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2842033003: NetEq: Add a VoidAudioSink tool (Closed)

Created:
3 years, 7 months ago by hlundin-webrtc
Modified:
3 years, 7 months ago
Reviewers:
*ivoc, AleBzk
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Add a VoidAudioSink tool This is to be used in tests where the audio output is not interesting. BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2842033003 Cr-Commit-Position: refs/heads/master@{#17893} Committed: https://chromium.googlesource.com/external/webrtc/+/a05d3c8efee8f212d6d25e6171231137aafc9375

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M webrtc/modules/audio_coding/neteq/tools/audio_sink.h View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/audio_sink.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
hlundin-webrtc
PTAL
3 years, 7 months ago (2017-04-26 14:53:23 UTC) #3
ivoc
On 2017/04/26 14:53:23, hlundin-webrtc wrote: > PTAL lgtm!
3 years, 7 months ago (2017-04-26 14:58:13 UTC) #4
AleBzk
lgtm
3 years, 7 months ago (2017-04-26 15:02:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2842033003/1
3 years, 7 months ago (2017-04-26 16:08:11 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 16:32:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/a05d3c8efee8f212d6d25e617...

Powered by Google App Engine
This is Rietveld 408576698