Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 2835093002: Reland of Change NetEq::InsertPacket to take an RTPHeader (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, kwiberg-webrtc, minyue-webrtc, ossu
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Change NetEq::InsertPacket to take an RTPHeader (patchset #1 id:1 of https://codereview.webrtc.org/2812933002/ ) Reason for revert: Downstream roadblock should be cleared by now. Relanding original patch. Original issue's description: > Revert of Change NetEq::InsertPacket to take an RTPHeader (patchset #2 id:20001 of https://codereview.webrtc.org/2807273004/ ) > > Reason for revert: > Broke downstream dependencies. > > Original issue's description: > > Change NetEq::InsertPacket to take an RTPHeader > > > > It used to take a WebRtcRTPHeader as input, which has an RTPHeader as > > a member. None of the other member in WebRtcRTPHeader where used in > > NetEq. > > > > This CL adapts the production code; tests and tools will be converted > > in a follow-up CL. > > > > BUG=webrtc:7467 > > > > Review-Url: https://codereview.webrtc.org/2807273004 > > Cr-Commit-Position: refs/heads/master@{#17652} > > Committed: https://chromium.googlesource.com/external/webrtc/+/4d027576a6f7420fc4ec6be7f4f991cfad34b826 > > TBR=ivoc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7467 > > Review-Url: https://codereview.webrtc.org/2812933002 > Cr-Commit-Position: refs/heads/master@{#17657} > Committed: https://chromium.googlesource.com/external/webrtc/+/10d095d4f743bc16f8e486e156c48a6d023b32c5 R=ivoc@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2835093002 . Cr-Commit-Position: refs/heads/master@{#17843} Committed: https://chromium.googlesource.com/external/webrtc/+/70c09bde41909e7bf221a070c17dfbd595bd360f

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
hlundin-webrtc
Created Reland of Change NetEq::InsertPacket to take an RTPHeader
3 years, 8 months ago (2017-04-24 06:57:27 UTC) #1
ivoc
On 2017/04/24 06:57:27, hlundin-webrtc wrote: > Created Reland of Change NetEq::InsertPacket to take an RTPHeader ...
3 years, 8 months ago (2017-04-24 07:55:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2835093002/1
3 years, 8 months ago (2017-04-24 09:29:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/437277)
3 years, 8 months ago (2017-04-24 12:07:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2835093002/1
3 years, 8 months ago (2017-04-24 12:08:54 UTC) #9
hlundin-webrtc
3 years, 8 months ago (2017-04-24 13:57:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70c09bde41909e7bf221a070c17dfbd595bd360f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698