Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2812933002: Revert of Change NetEq::InsertPacket to take an RTPHeader (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, ossu
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Change NetEq::InsertPacket to take an RTPHeader (patchset #2 id:20001 of https://codereview.webrtc.org/2807273004/ ) Reason for revert: Broke downstream dependencies. Original issue's description: > Change NetEq::InsertPacket to take an RTPHeader > > It used to take a WebRtcRTPHeader as input, which has an RTPHeader as > a member. None of the other member in WebRtcRTPHeader where used in > NetEq. > > This CL adapts the production code; tests and tools will be converted > in a follow-up CL. > > BUG=webrtc:7467 > > Review-Url: https://codereview.webrtc.org/2807273004 > Cr-Commit-Position: refs/heads/master@{#17652} > Committed: https://chromium.googlesource.com/external/webrtc/+/4d027576a6f7420fc4ec6be7f4f991cfad34b826 TBR=ivoc@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2812933002 Cr-Commit-Position: refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/10d095d4f743bc16f8e486e156c48a6d023b32c5

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Created Revert of Change NetEq::InsertPacket to take an RTPHeader
3 years, 8 months ago (2017-04-11 14:47:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2812933002/1
3 years, 8 months ago (2017-04-11 14:47:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/10d095d4f743bc16f8e486e156c48a6d023b32c5
3 years, 8 months ago (2017-04-11 14:48:10 UTC) #6
hlundin-webrtc
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2835093002/ by henrik.lundin@webrtc.org. ...
3 years, 8 months ago (2017-04-24 06:57:26 UTC) #7
ivoc
3 years, 8 months ago (2017-04-24 07:54:55 UTC) #8
Message was sent while issue was closed.
On 2017/04/24 06:57:26, hlundin-webrtc wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.webrtc.org/2835093002/ by mailto:henrik.lundin@webrtc.org.
> 
> The reason for reverting is: Downstream roadblock should be cleared by now.
> Relanding original patch..

lgtm.

Powered by Google App Engine
This is Rietveld 408576698