Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2807273004: Change NetEq::InsertPacket to take an RTPHeader (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, ossu
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change NetEq::InsertPacket to take an RTPHeader It used to take a WebRtcRTPHeader as input, which has an RTPHeader as a member. None of the other member in WebRtcRTPHeader where used in NetEq. This CL adapts the production code; tests and tools will be converted in a follow-up CL. BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2807273004 Cr-Commit-Position: refs/heads/master@{#17652} Committed: https://chromium.googlesource.com/external/webrtc/+/4d027576a6f7420fc4ec6be7f4f991cfad34b826

Patch Set 1 #

Patch Set 2 : git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -97 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/include/neteq.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 6 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 18 chunks +21 lines, -21 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 22 chunks +44 lines, -42 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
hlundin-webrtc
Ivo, please, take a look.
3 years, 8 months ago (2017-04-11 09:51:43 UTC) #2
ivoc
lgtm!
3 years, 8 months ago (2017-04-11 12:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2807273004/20001
3 years, 8 months ago (2017-04-11 12:52:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/4d027576a6f7420fc4ec6be7f4f991cfad34b826
3 years, 8 months ago (2017-04-11 13:17:50 UTC) #8
hlundin-webrtc
3 years, 8 months ago (2017-04-11 14:47:49 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2812933002/ by henrik.lundin@webrtc.org.

The reason for reverting is: Broke downstream dependencies..

Powered by Google App Engine
This is Rietveld 408576698