Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2809153002: Change from WebRtcRTPHeader to RTPHeader in NetEq tests and tools (Closed)

Created:
3 years, 8 months ago by hlundin-webrtc
Modified:
3 years, 8 months ago
Reviewers:
ivoc, kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, ossu
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change from WebRtcRTPHeader to RTPHeader in NetEq tests and tools With this CL, all tests and tools under the neteq/ folder are converted to use RTPHeader instead of WebRtcRTPHeader. WebRtcRTPHeader has an RTPHeader as a member. None of the other member in WebRtcRTPHeader where used. TBR=kjellander@webrtc.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_rel_ng,linux_chromium_compile_dbg_ng BUG=webrtc:7467 Review-Url: https://codereview.webrtc.org/2809153002 Cr-Commit-Position: refs/heads/master@{#17845} Committed: https://chromium.googlesource.com/external/webrtc/+/246ef3ea0ec559a78a651096ea81cbfe5b7bf792

Patch Set 1 #

Patch Set 2 : Fixing neteq_rtp_fuzzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -269 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 29 chunks +113 lines, -113 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 26 chunks +78 lines, -79 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/encode_neteq_input.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_input.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_packet_source_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_replacement_input.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.h View 2 chunks +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_generator.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_generator.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M webrtc/test/fuzzers/neteq_rtp_fuzzer.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (13 generated)
hlundin-webrtc
Ivo, please, take a look at this too.
3 years, 8 months ago (2017-04-11 09:53:28 UTC) #2
ivoc
Nice change, lgtm!
3 years, 8 months ago (2017-04-11 14:33:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2809153002/1
3 years, 8 months ago (2017-04-24 14:51:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/builds/11955)
3 years, 8 months ago (2017-04-24 15:00:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2809153002/20001
3 years, 8 months ago (2017-04-24 15:27:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16392)
3 years, 8 months ago (2017-04-24 15:32:28 UTC) #14
hlundin-webrtc
TBR kjellander@ for fuzzer test.
3 years, 8 months ago (2017-04-24 16:11:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2809153002/20001
3 years, 8 months ago (2017-04-24 16:12:00 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 16:14:37 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/246ef3ea0ec559a78a651096e...

Powered by Google App Engine
This is Rietveld 408576698