Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2827223003: Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, daniela-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of GN: Enable ARC for Mac and iOS in rtc_* templates (patchset #3 id:40001 of https://codereview.webrtc.org/2781713004/ ) Reason for revert: Breaks mac build Original issue's description: > GN: Enable ARC for Mac and iOS in rtc_* templates > > Remove all uses of retain/release and NSAutoreleasePool. > > This makes transformation to Bazel easier. > > This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ > > BUG=webrtc:6412 > > Review-Url: https://codereview.webrtc.org/2781713004 > Cr-Commit-Position: refs/heads/master@{#17780} > Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47 TBR=kjellander@webrtc.org,magjed@webrtc.org,stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2827223003 Cr-Commit-Position: refs/heads/master@{#17784} Committed: https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -31 lines) Patch
M webrtc/examples/BUILD.gn View 6 chunks +12 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 4 chunks +16 lines, -4 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/mac/run_test.mm View 2 chunks +19 lines, -18 lines 0 comments Download
M webrtc/test/mac/video_renderer_mac.mm View 3 chunks +8 lines, -2 lines 0 comments Download
M webrtc/webrtc.gni View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
Created Revert of GN: Enable ARC for Mac and iOS in rtc_* templates
3 years, 8 months ago (2017-04-20 10:54:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2827223003/1
3 years, 8 months ago (2017-04-20 10:54:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/7c8786ae8f2d8481f74b0ab16eb91a8101fe51dc
3 years, 8 months ago (2017-04-20 10:54:28 UTC) #6
kjellander_webrtc
lgtm, but for future reference - please provide at least one buildbot link in case ...
3 years, 8 months ago (2017-04-20 11:01:33 UTC) #7
kthelgason
3 years, 8 months ago (2017-04-22 19:27:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2834273002/ by kthelgason@webrtc.org.

The reason for reverting is: Relanding after fixing ARC issue..

Powered by Google App Engine
This is Rietveld 408576698