Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2781713004: GN: Enable ARC for Mac and iOS in rtc_* templates (Closed)

Created:
3 years, 8 months ago by kthelgason
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, sdk-team_agora.io, peah-webrtc, daniela-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Enable ARC for Mac and iOS in rtc_* templates Remove all uses of retain/release and NSAutoreleasePool. This makes transformation to Bazel easier. This CL subsumes https://codereview.webrtc.org/2778163002 and depends on https://codereview.webrtc.org/2784483002/ BUG=webrtc:6412 Review-Url: https://codereview.webrtc.org/2781713004 Cr-Commit-Position: refs/heads/master@{#17780} Committed: https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -61 lines) Patch
M webrtc/examples/BUILD.gn View 1 2 6 chunks +2 lines, -12 lines 0 comments Download
M webrtc/modules/audio_device/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 4 chunks +4 lines, -16 lines 0 comments Download
M webrtc/sdk/objc/Framework/UnitTests/avformatmappertests.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/mac/run_test.mm View 2 chunks +18 lines, -19 lines 0 comments Download
M webrtc/test/mac/video_renderer_mac.mm View 3 chunks +2 lines, -8 lines 0 comments Download
M webrtc/webrtc.gni View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
kthelgason
Note that this will not compile on the bots until https://codereview.webrtc.org/2784483002 lands.
3 years, 8 months ago (2017-03-28 13:54:47 UTC) #3
kjellander_webrtc
lgtm, thanks
3 years, 8 months ago (2017-03-28 18:39:38 UTC) #5
magjed_webrtc
lgtm
3 years, 8 months ago (2017-03-31 08:19:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781713004/20001
3 years, 8 months ago (2017-03-31 08:19:38 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/builds/3033) ios_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 8 months ago (2017-03-31 08:21:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781713004/40001
3 years, 8 months ago (2017-03-31 08:35:08 UTC) #20
kthelgason
Stefan, can you stamp this as well? I need an owner for mouse_cursor_monitor_mac
3 years, 8 months ago (2017-03-31 08:39:46 UTC) #22
kthelgason
Stefan, can you stamp this as well? I need an owner for mouse_cursor_monitor_mac
3 years, 8 months ago (2017-03-31 08:39:47 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15637)
3 years, 8 months ago (2017-03-31 08:40:19 UTC) #25
stefan-webrtc
lgtm webrtc/webrtc.gni
3 years, 8 months ago (2017-04-20 08:10:30 UTC) #26
stefan-webrtc
lgtm also for modules/desktop_capture
3 years, 8 months ago (2017-04-20 08:21:09 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2781713004/40001
3 years, 8 months ago (2017-04-20 08:21:40 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/6bda02b51dc00401d2a0d04be996ed10e5acac47
3 years, 8 months ago (2017-04-20 08:38:06 UTC) #32
kthelgason
3 years, 8 months ago (2017-04-20 10:54:09 UTC) #33
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2827223003/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks mac build.

Powered by Google App Engine
This is Rietveld 408576698