Issue 2778163002: GN: Enable ARC for Mac and iOS in rtc_* templates

Issue 2778163002: GN: Enable ARC for Mac and iOS in rtc_* templates (Closed)

Created:
3 years, 8 months ago by kjellander_webrtc

Modified:
3 years, 8 months ago

Reviewers:
kthelgason

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc

Target Ref:
refs/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

GN: Enable ARC for Mac and iOS in rtc_* templates This makes transformation to Bazel easier. BUG=webrtc:6412

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -36 lines)			Patch
M	webrtc/examples/BUILD.gn	View	5 chunks	+5 lines, -20 lines	0 comments	Download
M	webrtc/sdk/BUILD.gn	View	4 chunks	+4 lines, -16 lines	0 comments	Download
M	webrtc/webrtc.gni	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kjellander_webrtc

Kari, can you take over this CL and fix the compile errors? I get: ninja: ...

3 years, 8 months ago (2017-03-28 08:15:35 UTC) #2

Kari, can you take over this CL and fix the compile errors?
I get: 

ninja: Entering directory `out/Release'
[1/1] Regenerating ninja files
[1641/3484] OBJCXX obj/webrtc/base/rtc_base/maccocoathreadhelper.o
FAILED: obj/webrtc/base/rtc_base/maccocoathreadhelper.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/webrtc/base/rtc_base/maccocoathreadhelper.o.d -DV8_DEPRECATION_WARNINGS
-DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=\"298539-1\" -DCR_XCODE_VERSION=0821
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE
-DEXPAT_RELATIVE_PATH -DHAVE_SCTP -DWEBRTC_POSIX -DWEBRTC_MAC -I../.. -Igen
-I../../third_party/jsoncpp/overrides/include
-I../../third_party/jsoncpp/source/include
-I../../third_party/boringssl/src/include -Wno-uninitialized
-fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__=
-D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -arch x86_64 -O2 -gdwarf-2
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
-mmacosx-version-min=10.9 -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Wheader-hygiene
-Wstring-conversion -Wtautological-overlap-compare -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wno-strict-overflow -Wimplicit-fallthrough
-Wthread-safety -Winconsistent-missing-override -Wundef -Werror -Wall
-Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-deprecated-register -Wno-unneeded-internal-declaration
-Wno-inconsistent-missing-override -Wno-shift-negative-value
-Wno-undefined-var-template -Wno-nonportable-include-path
-Wno-address-of-packed-member -Wno-unused-lambda-capture
-Wno-user-defined-warnings -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++
-fobjc-call-cxx-cdtors -fno-rtti -fno-exceptions -fobjc-arc -c
../../webrtc/base/maccocoathreadhelper.mm -o
obj/webrtc/base/rtc_base/maccocoathreadhelper.o
../../webrtc/base/maccocoathreadhelper.mm:30:5: error: 'NSAutoreleasePool' is
unavailable: not available in automatic reference counting mode
    NSAutoreleasePool* hack;
    ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAutoreleasePool.h:10:12:
note: 'NSAutoreleasePool' has been explicitly marked unavailable here
@interface NSAutoreleasePool : NSObject {
           ^
../../webrtc/base/maccocoathreadhelper.mm:31:14: error: 'NSAutoreleasePool' is
unavailable: not available in automatic reference counting mode
    hack = [[NSAutoreleasePool alloc] init];
             ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAutoreleasePool.h:10:12:
note: 'NSAutoreleasePool' has been explicitly marked unavailable here
@interface NSAutoreleasePool : NSObject {
           ^
2 errors generated.
[1644/3484] OBJCXX obj/webrtc/base/rtc_base/scoped_autorelease_pool.o
FAILED: obj/webrtc/base/rtc_base/scoped_autorelease_pool.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/webrtc/base/rtc_base/scoped_autorelease_pool.o.d -DV8_DEPRECATION_WARNINGS
-DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=\"298539-1\" -DCR_XCODE_VERSION=0821
-D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE
-DEXPAT_RELATIVE_PATH -DHAVE_SCTP -DWEBRTC_POSIX -DWEBRTC_MAC -I../.. -Igen
-I../../third_party/jsoncpp/overrides/include
-I../../third_party/jsoncpp/source/include
-I../../third_party/boringssl/src/include -Wno-uninitialized
-fno-strict-aliasing -fstack-protector -Wno-builtin-macro-redefined -D__DATE__=
-D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -arch x86_64 -O2 -gdwarf-2
-isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk
-mmacosx-version-min=10.9 -fvisibility=hidden -Xclang -load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-auto-raw-pointer -Wheader-hygiene
-Wstring-conversion -Wtautological-overlap-compare -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wno-strict-overflow -Wimplicit-fallthrough
-Wthread-safety -Winconsistent-missing-override -Wundef -Werror -Wall
-Wno-unused-variable -Wpartial-availability -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default
-Wno-deprecated-register -Wno-unneeded-internal-declaration
-Wno-inconsistent-missing-override -Wno-shift-negative-value
-Wno-undefined-var-template -Wno-nonportable-include-path
-Wno-address-of-packed-member -Wno-unused-lambda-capture
-Wno-user-defined-warnings -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++
-fobjc-call-cxx-cdtors -fno-rtti -fno-exceptions -fobjc-arc -c
../../webrtc/base/scoped_autorelease_pool.mm -o
obj/webrtc/base/rtc_base/scoped_autorelease_pool.o
In file included from ../../webrtc/base/scoped_autorelease_pool.mm:13:
../../webrtc/base/scoped_autorelease_pool.h:51:3: error: 'NSAutoreleasePool' is
unavailable: not available in automatic reference counting mode
  NSAutoreleasePool* pool_;
  ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAutoreleasePool.h:10:12:
note: 'NSAutoreleasePool' has been explicitly marked unavailable here
@interface NSAutoreleasePool : NSObject {
           ^
../../webrtc/base/scoped_autorelease_pool.mm:18:13: error: 'NSAutoreleasePool'
is unavailable: not available in automatic reference counting mode
  pool_ = [[NSAutoreleasePool alloc] init];
            ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.12.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSAutoreleasePool.h:10:12:
note: 'NSAutoreleasePool' has been explicitly marked unavailable here
@interface NSAutoreleasePool : NSObject {
           ^
2 errors generated.
[1650/3484] CXX obj/webrtc/base/rtc_base/virtualsocketserver.o
ninja: build stopped: subcommand failed.

kjellander_webrtc

3 years, 8 months ago (2017-03-28 18:39:22 UTC) #4

Message was sent while issue was closed.

Closing this in favor for https://codereview.webrtc.org/2781713004/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages