Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 2814693002: Reland of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2812553002/ ) Reason for revert: Downstream project updated. Original issue's description: > Revert of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2808463002/ ) > > Reason for revert: > Deleting scopedptrcollection.h broke an internal project. > > Original issue's description: > > Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2808463002 > > Cr-Commit-Position: refs/heads/master@{#17605} > > Committed: https://chromium.googlesource.com/external/webrtc/+/188596f20fb7f206ea3d1b8c48ca47304853c9fb > > TBR=pthatcher@webrtc.org,kwiberg@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2812553002 > Cr-Commit-Position: refs/heads/master@{#17607} > Committed: https://chromium.googlesource.com/external/webrtc/+/2042c16be026f44a66dda8373ed812ce38fd2a55 TBR=pthatcher@webrtc.org,kwiberg@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/2814693002 Cr-Commit-Position: refs/heads/master@{#17781} Committed: https://chromium.googlesource.com/external/webrtc/+/b9c2f7ceebdb4cb652743702a1c5fa16ef0c9333

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -148 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection_unittest.cc View 7 chunks +8 lines, -9 lines 1 comment Download
D webrtc/base/scopedptrcollection.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/base/scopedptrcollection_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
nisse-webrtc
Created Reland of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr.
3 years, 8 months ago (2017-04-11 09:43:22 UTC) #1
nisse-webrtc
Downstream projects now updated. Intend to land as soon as the internal-bot goes green.
3 years, 8 months ago (2017-04-20 08:24:44 UTC) #6
kwiberg-webrtc
lgtm https://codereview.webrtc.org/2814693002/diff/1/webrtc/base/criticalsection_unittest.cc File webrtc/base/criticalsection_unittest.cc (right): https://codereview.webrtc.org/2814693002/diff/1/webrtc/base/criticalsection_unittest.cc#newcode204 webrtc/base/criticalsection_unittest.cc:204: std::unique_ptr<Thread> thread(new Thread()); Nit: You could use MakeUnique. ...
3 years, 8 months ago (2017-04-20 08:43:30 UTC) #7
nisse-webrtc
On 2017/04/20 08:43:30, kwiberg-webrtc wrote: > lgtm > > https://codereview.webrtc.org/2814693002/diff/1/webrtc/base/criticalsection_unittest.cc > File webrtc/base/criticalsection_unittest.cc (right): > ...
3 years, 8 months ago (2017-04-20 09:06:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2814693002/1
3 years, 8 months ago (2017-04-20 09:06:16 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 09:23:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b9c2f7ceebdb4cb652743702a...

Powered by Google App Engine
This is Rietveld 408576698