Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2808463002: Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. BUG=None Review-Url: https://codereview.webrtc.org/2808463002 Cr-Commit-Position: refs/heads/master@{#17605} Committed: https://chromium.googlesource.com/external/webrtc/+/188596f20fb7f206ea3d1b8c48ca47304853c9fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -148 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/base/criticalsection_unittest.cc View 7 chunks +8 lines, -9 lines 0 comments Download
D webrtc/base/scopedptrcollection.h View 1 chunk +0 lines, -61 lines 0 comments Download
D webrtc/base/scopedptrcollection_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
nisse-webrtc
PTAL.
3 years, 8 months ago (2017-04-07 13:08:41 UTC) #2
nisse-webrtc
cc +kwiberg.
3 years, 8 months ago (2017-04-07 13:09:32 UTC) #3
kwiberg-webrtc
lgtm
3 years, 8 months ago (2017-04-07 13:32:13 UTC) #5
pthatcher1
lgtm
3 years, 8 months ago (2017-04-07 22:25:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808463002/1
3 years, 8 months ago (2017-04-10 06:43:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/188596f20fb7f206ea3d1b8c48ca47304853c9fb
3 years, 8 months ago (2017-04-10 07:02:57 UTC) #11
nisse-webrtc
3 years, 8 months ago (2017-04-10 07:31:22 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2812553002/ by nisse@webrtc.org.

The reason for reverting is: Deleting scopedptrcollection.h broke an internal
project..

Powered by Google App Engine
This is Rietveld 408576698