Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2812553002: Revert of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (Closed)

Created:
3 years, 8 months ago by nisse-webrtc
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kwiberg-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2808463002/ ) Reason for revert: Deleting scopedptrcollection.h broke an internal project. Original issue's description: > Delete class ScopedPtrCollection. Replaced with vector of unique_ptr. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2808463002 > Cr-Commit-Position: refs/heads/master@{#17605} > Committed: https://chromium.googlesource.com/external/webrtc/+/188596f20fb7f206ea3d1b8c48ca47304853c9fb TBR=pthatcher@webrtc.org,kwiberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2812553002 Cr-Commit-Position: refs/heads/master@{#17607} Committed: https://chromium.googlesource.com/external/webrtc/+/2042c16be026f44a66dda8373ed812ce38fd2a55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -8 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/criticalsection_unittest.cc View 7 chunks +9 lines, -8 lines 0 comments Download
A webrtc/base/scopedptrcollection.h View 1 chunk +61 lines, -0 lines 0 comments Download
A webrtc/base/scopedptrcollection_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Delete class ScopedPtrCollection. Replaced with vector of unique_ptr.
3 years, 8 months ago (2017-04-10 07:31:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2812553002/1
3 years, 8 months ago (2017-04-10 07:31:31 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/2042c16be026f44a66dda8373ed812ce38fd2a55
3 years, 8 months ago (2017-04-10 07:31:37 UTC) #6
nisse-webrtc
3 years, 8 months ago (2017-04-11 09:43:21 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2814693002/ by nisse@webrtc.org.

The reason for reverting is: Downstream project updated..

Powered by Google App Engine
This is Rietveld 408576698