Chromium Code Reviews

Issue 2813363004: Reland of Android Logging.java: Load native library only when needed (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
AlexG, brandtr, noahric, lliuu, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android Logging.java: Load native library only when needed (patchset #1 id:1 of https://codereview.webrtc.org/2814133002/ ) Reason for revert: Fix bug in original CL. Original issue's description: > Revert of Android Logging.java: Load native library only when needed (patchset #2 id:2 of https://codereview.webrtc.org/2817593003/ ) > > Reason for revert: > Change in Logging.java breaking compilation (incorrect reference to enum) > > Original issue's description: > > Reland of Android Logging.java: Load native library only when needed (patchset #1 id:1 of https://codereview.webrtc.org/2816753002/ ) > > > > Reason for revert: > > Fix bug in original CL. > > > > Original issue's description: > > > Revert of Android Logging.java: Load native library only when needed (patchset #3 id:40001 of https://codereview.webrtc.org/2803203002/ ) > > > > > > Reason for revert: > > > Breaks C++ logs in Java apps. > > > > > > Original issue's description: > > > > Android Logging.java: Load native library only when needed > > > > > > > > Logging.java currently always tries to load jingle_peerconnection_so in > > > > the static section, but some clients don't want to use it. This CL loads > > > > jingle_peerconnection_so only when a client requests it by calling one > > > > of: > > > > * Logging.enableLogThreads > > > > * Logging.enableLogTimeStamps > > > > * Logging.enableTracing > > > > * Logging.enableLogToDebugOutput > > > > > > > > BUG=b/36410678 > > > > > > > > Review-Url: https://codereview.webrtc.org/2803203002 > > > > Cr-Commit-Position: refs/heads/master@{#17647} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/dee5eb14e1d4e5bd894772448cc9418e94b3a967 > > > > > > TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,magjed@webrtc.org > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > BUG=b/36410678 > > > > > > Review-Url: https://codereview.webrtc.org/2816753002 > > > Cr-Commit-Position: refs/heads/master@{#17676} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/6e4a4427dc58ca252461310981e1f07ed987c334 > > > > TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,brandtr@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=b/36410678 > > > > Review-Url: https://codereview.webrtc.org/2817593003 > > Cr-Commit-Position: refs/heads/master@{#17677} > > Committed: https://chromium.googlesource.com/external/webrtc/+/297714619fc4252c08ef8a04ac4ca18653c70b39 > > TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,brandtr@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=b/36410678 > > Review-Url: https://codereview.webrtc.org/2814133002 > Cr-Commit-Position: refs/heads/master@{#17678} > Committed: https://chromium.googlesource.com/external/webrtc/+/06034c7d6401b8e447aac98fd062b87523ae5f4f TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,brandtr@webrtc.org,lliuu@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=b/36410678 Review-Url: https://codereview.webrtc.org/2813363004 Cr-Commit-Position: refs/heads/master@{#17694} Committed: https://chromium.googlesource.com/external/webrtc/+/282d49f0ca9e9593ce621472b646a6b025436f80

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Stats (+40 lines, -15 lines)
M webrtc/base/java/src/org/webrtc/Logging.java View 5 chunks +32 lines, -15 lines 0 comments
M webrtc/sdk/android/api/org/webrtc/FileVideoCapturer.java View 1 chunk +4 lines, -0 lines 0 comments
M webrtc/sdk/android/api/org/webrtc/VideoFileRenderer.java View 1 chunk +4 lines, -0 lines 0 comments

Messages

Total messages: 11 (8 generated)
magjed_webrtc
Created Reland of Android Logging.java: Load native library only when needed
3 years, 8 months ago (2017-04-13 08:45:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2813363004/90001
3 years, 8 months ago (2017-04-13 11:13:41 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 11:17:06 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as
https://chromium.googlesource.com/external/webrtc/+/282d49f0ca9e9593ce621472b...

Powered by Google App Engine