Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2817593003: Reland of Android Logging.java: Load native library only when needed (Closed)

Created:
3 years, 8 months ago by magjed_webrtc
Modified:
3 years, 8 months ago
Reviewers:
AlexG, brandtr, noahric, sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android Logging.java: Load native library only when needed (patchset #1 id:1 of https://codereview.webrtc.org/2816753002/ ) Reason for revert: Fix bug in original CL. Original issue's description: > Revert of Android Logging.java: Load native library only when needed (patchset #3 id:40001 of https://codereview.webrtc.org/2803203002/ ) > > Reason for revert: > Breaks C++ logs in Java apps. > > Original issue's description: > > Android Logging.java: Load native library only when needed > > > > Logging.java currently always tries to load jingle_peerconnection_so in > > the static section, but some clients don't want to use it. This CL loads > > jingle_peerconnection_so only when a client requests it by calling one > > of: > > * Logging.enableLogThreads > > * Logging.enableLogTimeStamps > > * Logging.enableTracing > > * Logging.enableLogToDebugOutput > > > > BUG=b/36410678 > > > > Review-Url: https://codereview.webrtc.org/2803203002 > > Cr-Commit-Position: refs/heads/master@{#17647} > > Committed: https://chromium.googlesource.com/external/webrtc/+/dee5eb14e1d4e5bd894772448cc9418e94b3a967 > > TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,magjed@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=b/36410678 > > Review-Url: https://codereview.webrtc.org/2816753002 > Cr-Commit-Position: refs/heads/master@{#17676} > Committed: https://chromium.googlesource.com/external/webrtc/+/6e4a4427dc58ca252461310981e1f07ed987c334 TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,brandtr@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/36410678 Review-Url: https://codereview.webrtc.org/2817593003 Cr-Commit-Position: refs/heads/master@{#17677} Committed: https://chromium.googlesource.com/external/webrtc/+/297714619fc4252c08ef8a04ac4ca18653c70b39

Patch Set 1 #

Patch Set 2 : Initialize nativeLibStatus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -15 lines) Patch
M webrtc/base/java/src/org/webrtc/Logging.java View 1 5 chunks +32 lines, -15 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/FileVideoCapturer.java View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/VideoFileRenderer.java View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
magjed_webrtc
Created Reland of Android Logging.java: Load native library only when needed
3 years, 8 months ago (2017-04-12 17:01:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2817593003/2
3 years, 8 months ago (2017-04-12 17:03:29 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:2) as https://chromium.googlesource.com/external/webrtc/+/297714619fc4252c08ef8a04ac4ca18653c70b39
3 years, 8 months ago (2017-04-12 17:03:37 UTC) #6
lliuu
3 years, 8 months ago (2017-04-12 17:13:15 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:2) has been created in
https://codereview.webrtc.org/2814133002/ by lliuu@webrtc.org.

The reason for reverting is: Change in Logging.java breaking compilation
(incorrect reference to enum).

Powered by Google App Engine
This is Rietveld 408576698