Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2816753002: Revert of Android Logging.java: Load native library only when needed (Closed)

Created:
3 years, 8 months ago by brandtr
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Android Logging.java: Load native library only when needed (patchset #3 id:40001 of https://codereview.webrtc.org/2803203002/ ) Reason for revert: Breaks C++ logs in Java apps. Original issue's description: > Android Logging.java: Load native library only when needed > > Logging.java currently always tries to load jingle_peerconnection_so in > the static section, but some clients don't want to use it. This CL loads > jingle_peerconnection_so only when a client requests it by calling one > of: > * Logging.enableLogThreads > * Logging.enableLogTimeStamps > * Logging.enableTracing > * Logging.enableLogToDebugOutput > > BUG=b/36410678 > > Review-Url: https://codereview.webrtc.org/2803203002 > Cr-Commit-Position: refs/heads/master@{#17647} > Committed: https://chromium.googlesource.com/external/webrtc/+/dee5eb14e1d4e5bd894772448cc9418e94b3a967 TBR=sakal@webrtc.org,glaznev@webrtc.org,noahric@chromium.org,magjed@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=b/36410678 Review-Url: https://codereview.webrtc.org/2816753002 Cr-Commit-Position: refs/heads/master@{#17676} Committed: https://chromium.googlesource.com/external/webrtc/+/6e4a4427dc58ca252461310981e1f07ed987c334

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -40 lines) Patch
M webrtc/base/java/src/org/webrtc/Logging.java View 5 chunks +15 lines, -32 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/FileVideoCapturer.java View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/VideoFileRenderer.java View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brandtr
Created Revert of Android Logging.java: Load native library only when needed
3 years, 8 months ago (2017-04-12 16:09:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2816753002/1
3 years, 8 months ago (2017-04-12 16:09:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/6e4a4427dc58ca252461310981e1f07ed987c334
3 years, 8 months ago (2017-04-12 16:28:28 UTC) #6
magjed_webrtc
3 years, 8 months ago (2017-04-12 17:01:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2817593003/ by magjed@webrtc.org.

The reason for reverting is: Fix bug in original CL..

Powered by Google App Engine
This is Rietveld 408576698