Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2812213002: Add CSSInterpolationType specific ConversionChecker (Closed)

Created:
3 years, 8 months ago by alancutter (OOO until 2018)
Modified:
3 years, 7 months ago
Reviewers:
Eric Willigers
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CSSInterpolationType specific ConversionChecker This change refactors the CSS ConversionCheckers to inherit from a common CSSConversionChecker class that removes some of the boiler plate code in using the InterpolationEnvironment. This patch introduces no changes in behaviour. BUG=671904 Review-Url: https://codereview.chromium.org/2812213002 Cr-Commit-Position: refs/heads/master@{#474948} Committed: https://chromium.googlesource.com/chromium/src/+/feb42804d1fed874c8cd4c13cad9fddc86bdb32e

Patch Set 1 #

Patch Set 2 : _conversionCheckerCSSYay #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -137 lines) Patch
M third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp View 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.cpp View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp View 1 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp View 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthUnitsChecker.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
alancutter (OOO until 2018)
3 years, 7 months ago (2017-05-26 01:09:37 UTC) #4
Eric Willigers
lgtm
3 years, 7 months ago (2017-05-26 01:42:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812213002/60001
3 years, 7 months ago (2017-05-26 01:48:26 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 06:47:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/feb42804d1fed874c8cd4c13cad9...

Powered by Google App Engine
This is Rietveld 408576698