Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

Issue 2812213002: Add CSSInterpolationType specific ConversionChecker (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
index f3337ff9d5255aa10775e27851c93423b62cb594..b87eddb95b53813232a14082ef1e305855684da8 100644
--- a/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
@@ -47,7 +47,8 @@ InterpolationValue CSSShadowListInterpolationType::MaybeConvertInitial(
ShadowListPropertyFunctions::GetInitialShadowList(CssProperty()), 1);
}
-class InheritedShadowListChecker : public InterpolationType::ConversionChecker {
+class InheritedShadowListChecker
+ : public CSSInterpolationType::CSSConversionChecker {
public:
static std::unique_ptr<InheritedShadowListChecker> Create(
CSSPropertyID property,
@@ -61,11 +62,11 @@ class InheritedShadowListChecker : public InterpolationType::ConversionChecker {
PassRefPtr<ShadowList> shadow_list)
: property_(property), shadow_list_(std::move(shadow_list)) {}
- bool IsValid(const InterpolationEnvironment& environment,
+ bool IsValid(const StyleResolverState& state,
const InterpolationValue& underlying) const final {
const ShadowList* inherited_shadow_list =
- ShadowListPropertyFunctions::GetShadowList(
- property_, *environment.GetState().ParentStyle());
+ ShadowListPropertyFunctions::GetShadowList(property_,
+ *state.ParentStyle());
if (!inherited_shadow_list && !shadow_list_)
return true;
if (!inherited_shadow_list || !shadow_list_)

Powered by Google App Engine
This is Rietveld 408576698