Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp

Issue 2812213002: Add CSSInterpolationType specific ConversionChecker (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
index 57520a1cf779459dd237085c52b05856df6ce404..7fb7c8789cae383af0dcd0cb6e30131948cc6f50 100644
--- a/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
@@ -71,14 +71,14 @@ DEFINE_NON_INTERPOLABLE_VALUE_TYPE_CASTS(CSSTextIndentNonInterpolableValue);
namespace {
class UnderlyingIndentModeChecker
- : public InterpolationType::ConversionChecker {
+ : public CSSInterpolationType::CSSConversionChecker {
public:
static std::unique_ptr<UnderlyingIndentModeChecker> Create(
const IndentMode& mode) {
return WTF::WrapUnique(new UnderlyingIndentModeChecker(mode));
}
- bool IsValid(const InterpolationEnvironment&,
+ bool IsValid(const StyleResolverState&,
const InterpolationValue& underlying) const final {
return mode_ == ToCSSTextIndentNonInterpolableValue(
*underlying.non_interpolable_value)
@@ -91,16 +91,17 @@ class UnderlyingIndentModeChecker
const IndentMode mode_;
};
-class InheritedIndentModeChecker : public InterpolationType::ConversionChecker {
+class InheritedIndentModeChecker
+ : public CSSInterpolationType::CSSConversionChecker {
public:
static std::unique_ptr<InheritedIndentModeChecker> Create(
const IndentMode& mode) {
return WTF::WrapUnique(new InheritedIndentModeChecker(mode));
}
- bool IsValid(const InterpolationEnvironment& environment,
+ bool IsValid(const StyleResolverState& state,
const InterpolationValue&) const final {
- return mode_ == IndentMode(*environment.GetState().ParentStyle());
+ return mode_ == IndentMode(*state.ParentStyle());
}
private:

Powered by Google App Engine
This is Rietveld 408576698