Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them

Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )

Reason for revert:
Reland with temporary deprecated API to not break chromium and google3.

Original issue's description:
> Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ )
> 
> Reason for revert:
> Suspect of breaking Chrome FYI bots.
> 
> See
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder
> 
> Example logs:
> ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory
>  #include "third_party/webrtc/video_encoder.h"
>                                               ^
> 
> Original issue's description:
> > Move video_encoder.h and video_decoder.h to /api and create GN targets for them
> > 
> > BUG=webrtc:5881
> > # Because PRESUBMIT ignores LINT blacklist for moved files and these 
> > # headers have some not easy to resolve issues.
> > NOPRESUBMIT=True
> > 
> > Review-Url: https://codereview.webrtc.org/2780943003
> > Cr-Commit-Position: refs/heads/master@{#17511}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25
> 
> TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5881
> 
> Review-Url: https://codereview.webrtc.org/2794033002
> Cr-Commit-Position: refs/heads/master@{#17514}
> Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3

TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5881
Review-Url: https://codereview.webrtc.org/2795163002
Cr-Commit-Position: refs/heads/master@{#17537}
Committed: https://chromium.googlesource.com/external/webrtc/+/d60d06a9f971a36c9a51ff9919850cffb993893c

[ilnik, 2017-04-04 07:44:04]

Created Reland of Move video_encoder.h and video_decoder.h to /api and create GN
targets for them

[ilnik, 2017-04-04 07:44:54]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-04 07:44:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-04 07:45:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-04 07:45:00]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-04-04 08:07:50]

Description was changed from

==========
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets
for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )

Reason for revert:
That change will break chrome builders and it is normal.

Original issue's description:
> Revert of Move video_encoder.h and video_decoder.h to /api and create GN
targets for them (patchset #8 id:140001 of
https://codereview.webrtc.org/2780943003/ )
> 
> Reason for revert:
> Suspect of breaking Chrome FYI bots.
> 
> See
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder
> 
> Example logs:
> ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal
error: third_party/webrtc/video_encoder.h: No such file or directory
>  #include "third_party/webrtc/video_encoder.h"
>                                               ^
> 
> Original issue's description:
> > Move video_encoder.h and video_decoder.h to /api and create GN targets for
them
> > 
> > BUG=webrtc:5881
> > # Because PRESUBMIT ignores LINT blacklist for moved files and these 
> > # headers have some not easy to resolve issues.
> > NOPRESUBMIT=True
> > 
> > Review-Url: https://codereview.webrtc.org/2780943003
> > Cr-Commit-Position: refs/heads/master@{#17511}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...
> 
> TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5881
> 
> Review-Url: https://codereview.webrtc.org/2794033002
> Cr-Commit-Position: refs/heads/master@{#17514}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b340...

TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5881
==========

to

==========
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets
for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )

Reason for revert:
Reland with temporary deprecated API to not break chromium and google3.

Original issue's description:
> Revert of Move video_encoder.h and video_decoder.h to /api and create GN
targets for them (patchset #8 id:140001 of
https://codereview.webrtc.org/2780943003/ )
> 
> Reason for revert:
> Suspect of breaking Chrome FYI bots.
> 
> See
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder
> 
> Example logs:
> ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal
error: third_party/webrtc/video_encoder.h: No such file or directory
>  #include "third_party/webrtc/video_encoder.h"
>                                               ^
> 
> Original issue's description:
> > Move video_encoder.h and video_decoder.h to /api and create GN targets for
them
> > 
> > BUG=webrtc:5881
> > # Because PRESUBMIT ignores LINT blacklist for moved files and these 
> > # headers have some not easy to resolve issues.
> > NOPRESUBMIT=True
> > 
> > Review-Url: https://codereview.webrtc.org/2780943003
> > Cr-Commit-Position: refs/heads/master@{#17511}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...
> 
> TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5881
> 
> Review-Url: https://codereview.webrtc.org/2794033002
> Cr-Commit-Position: refs/heads/master@{#17514}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b340...

TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5881
==========

[kjellander (google.com), 2017-04-04 10:14:30]

kjellander@google.com changed reviewers:
+ kjellander@google.com

[kjellander (google.com), 2017-04-04 10:14:31]

The trybots are failing since you're missing an s in the include paths

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_decoder.h
File webrtc/video_decoder.h (right):

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_decoder.h#n...
webrtc/video_decoder.h:15: #include "webrtc/api/video_codec/video_decoder.h"
This should be
#include "webrtc/api/video_codecs/video_decoder.h"

Notice the 's' at video_cdoecs.

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_encoder.h
File webrtc/video_encoder.h (right):

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_encoder.h#n...
webrtc/video_encoder.h:15: #include "webrtc/api/video_codec/video_encoder.h"
video_codecs

[ilnik, 2017-04-04 10:20:35]

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_decoder.h
File webrtc/video_decoder.h (right):

https://codereview.webrtc.org/2795163002/diff/160003/webrtc/video_decoder.h#n...
webrtc/video_decoder.h:15: #include "webrtc/api/video_codec/video_decoder.h"
On 2017/04/04 10:14:30, kjellander (google.com) wrote:
> This should be
> #include "webrtc/api/video_codecs/video_decoder.h"
> 
> Notice the 's' at video_cdoecs.

Thank you! This is a very stupid mistake.

[the sun, 2017-04-04 18:58:55]

lgtm % the failing bot

[ilnik, 2017-04-05 10:02:04]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-04-05 10:02:05]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2795163002/#ps500001 (title:
"Fix typo")

[commit-bot: I haz the power, 2017-04-05 10:02:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-05 10:02:20]

CQ is committing da patch.

Bot data: {"patchset_id": 500001, "attempt_start_ts": 1491386524871620,
"parent_rev": "d8ce1e172e2bb3978f9b52d2373f2ccb8ccc1c16", "commit_rev":
"d60d06a9f971a36c9a51ff9919850cffb993893c"}

[commit-bot: I haz the power, 2017-04-05 10:02:24]

Description was changed from

==========
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets
for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )

Reason for revert:
Reland with temporary deprecated API to not break chromium and google3.

Original issue's description:
> Revert of Move video_encoder.h and video_decoder.h to /api and create GN
targets for them (patchset #8 id:140001 of
https://codereview.webrtc.org/2780943003/ )
> 
> Reason for revert:
> Suspect of breaking Chrome FYI bots.
> 
> See
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder
> 
> Example logs:
> ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal
error: third_party/webrtc/video_encoder.h: No such file or directory
>  #include "third_party/webrtc/video_encoder.h"
>                                               ^
> 
> Original issue's description:
> > Move video_encoder.h and video_decoder.h to /api and create GN targets for
them
> > 
> > BUG=webrtc:5881
> > # Because PRESUBMIT ignores LINT blacklist for moved files and these 
> > # headers have some not easy to resolve issues.
> > NOPRESUBMIT=True
> > 
> > Review-Url: https://codereview.webrtc.org/2780943003
> > Cr-Commit-Position: refs/heads/master@{#17511}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...
> 
> TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5881
> 
> Review-Url: https://codereview.webrtc.org/2794033002
> Cr-Commit-Position: refs/heads/master@{#17514}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b340...

TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5881
==========

to

==========
Reland of Move video_encoder.h and video_decoder.h to /api and create GN targets
for them (patchset #1 id:1 of https://codereview.webrtc.org/2794033002/ )

Reason for revert:
Reland with temporary deprecated API to not break chromium and google3.

Original issue's description:
> Revert of Move video_encoder.h and video_decoder.h to /api and create GN
targets for them (patchset #8 id:140001 of
https://codereview.webrtc.org/2780943003/ )
> 
> Reason for revert:
> Suspect of breaking Chrome FYI bots.
> 
> See
>
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
> https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder
> 
> Example logs:
> ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal
error: third_party/webrtc/video_encoder.h: No such file or directory
>  #include "third_party/webrtc/video_encoder.h"
>                                               ^
> 
> Original issue's description:
> > Move video_encoder.h and video_decoder.h to /api and create GN targets for
them
> > 
> > BUG=webrtc:5881
> > # Because PRESUBMIT ignores LINT blacklist for moved files and these 
> > # headers have some not easy to resolve issues.
> > NOPRESUBMIT=True
> > 
> > Review-Url: https://codereview.webrtc.org/2780943003
> > Cr-Commit-Position: refs/heads/master@{#17511}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...
> 
> TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:5881
> 
> Review-Url: https://codereview.webrtc.org/2794033002
> Cr-Commit-Position: refs/heads/master@{#17514}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b340...

TBR=solenberg@webrtc.org,sprang@webrtc.org,guidou@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:5881

Review-Url: https://codereview.webrtc.org/2795163002
Cr-Commit-Position: refs/heads/master@{#17537}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d60d06a9f971a36c9a51ff991...
==========

[commit-bot: I haz the power, 2017-04-05 10:02:25]

Committed patchset #13 (id:500001) as
https://chromium.googlesource.com/external/webrtc/+/d60d06a9f971a36c9a51ff991...