Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2794033002: Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (Closed)

Created:
3 years, 8 months ago by guidou
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them (patchset #8 id:140001 of https://codereview.webrtc.org/2780943003/ ) Reason for revert: Suspect of breaking Chrome FYI bots. See https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/23065 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder Example logs: ../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal error: third_party/webrtc/video_encoder.h: No such file or directory #include "third_party/webrtc/video_encoder.h" ^ Original issue's description: > Move video_encoder.h and video_decoder.h to /api and create GN targets for them > > BUG=webrtc:5881 > # Because PRESUBMIT ignores LINT blacklist for moved files and these > # headers have some not easy to resolve issues. > NOPRESUBMIT=True > > Review-Url: https://codereview.webrtc.org/2780943003 > Cr-Commit-Position: refs/heads/master@{#17511} > Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25 TBR=solenberg@webrtc.org,sprang@webrtc.org,ilnik@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5881 Review-Url: https://codereview.webrtc.org/2794033002 Cr-Commit-Position: refs/heads/master@{#17514} Committed: https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -373 lines) Patch
M PRESUBMIT.py View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
D webrtc/api/video_codecs/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/api/video_codecs/video_decoder.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webrtc/api/video_codecs/video_encoder.h View 1 chunk +0 lines, -192 lines 0 comments Download
M webrtc/media/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideoengine.h View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/videodecodersoftwarefallbackwrapper_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 3 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/video_codec_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_rate_allocator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/include/video_codec_interface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc View 11 chunks +27 lines, -30 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/configurable_frame_size_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video/payload_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/replay.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video/video_receive_stream_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +1 line, -1 line 0 comments Download
A webrtc/video_decoder.h View 1 chunk +86 lines, -0 lines 0 comments Download
A webrtc/video_encoder.h View 1 chunk +192 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
guidou
Created Revert of Move video_encoder.h and video_decoder.h to /api and create GN targets for them
3 years, 8 months ago (2017-04-03 16:15:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2794033002/1
3 years, 8 months ago (2017-04-03 16:15:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/716d7ac5c1ed6e392e264b34065800bbf03772b3
3 years, 8 months ago (2017-04-03 16:15:57 UTC) #6
ilnik
3 years, 8 months ago (2017-04-04 07:44:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2795163002/ by ilnik@webrtc.org.

The reason for reverting is: That change will break chrome builders and it is
normal..

Powered by Google App Engine
This is Rietveld 408576698