Move video_encoder.h and video_decoder.h to /api and create GN targets for them

Move video_encoder.h and video_decoder.h to /api and create GN targets for them

BUG=webrtc:5881
# Because PRESUBMIT ignores LINT blacklist for moved files and these 
# headers have some not easy to resolve issues.
NOPRESUBMIT=True

Review-Url: https://codereview.webrtc.org/2780943003
Cr-Commit-Position: refs/heads/master@{#17511}
Committed: https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57582577bfb9aed25

[ilnik, 2017-03-29 10:36:52]

ilnik@webrtc.org changed reviewers:
+ solenberg@webrtc.org, sprang@webrtc.org

[ilnik, 2017-03-29 11:25:04]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 11:25:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 11:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:29:03]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/20310)

[ilnik, 2017-03-29 11:50:17]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 11:50:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 11:51:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 11:51:31]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED, build hasn't started yet,
builder probably lacks capacity)

[ilnik, 2017-03-29 12:00:36]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 12:00:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-29 12:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 12:01:49]

Dry run: Try jobs failed on following builders:
  linux_arm on master.tryserver.webrtc (JOB_FAILED, build hasn't started yet,
builder probably lacks capacity)

[the sun, 2017-03-30 08:10:36]

Thanks for doing this!

Looks good, but I think it'd make sense to use the same directory and build
target structure as for the audio codecs api (which we've just built and
bike-shedded about enough). Do you think that'd be feasible?

https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py#newcode41
PRESUBMIT.py:41: 'webrtc/api/video_decoder.h',
1. List should be sorted.
2. Move the files to webrtc/api/video_codec/ instead (that matches the structure
for audio).

[ilnik, 2017-03-30 11:15:57]

https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py#newcode41
PRESUBMIT.py:41: 'webrtc/api/video_decoder.h',
On 2017/03/30 08:10:36, the sun wrote:
> 1. List should be sorted.
> 2. Move the files to webrtc/api/video_codec/ instead (that matches the
structure
> for audio).

Done.

[ilnik, 2017-03-30 11:16:05]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 11:16:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 11:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 11:18:04]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/19103)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/24398)

[ilnik, 2017-03-30 11:58:23]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 11:58:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 12:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 12:04:01]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15618)

[ilnik, 2017-03-30 12:07:32]

Description was changed from

==========
Move video_encoder.h and video_decoder.h to /api and create GN targets for them

BUG=webrtc:5881
==========

to

==========
Move video_encoder.h and video_decoder.h to /api and create GN targets for them

BUG=webrtc:5881
# Because PRESUBMIT ignores LINT blacklist for moved files and these 
# headers have some not easy to resolve issues.
NOPRESUBMIT=True
==========

[ilnik, 2017-03-30 12:07:49]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 12:08:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 12:25:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 12:25:52]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-03-30 14:48:12]

On 2017/03/30 11:15:57, ilnik wrote:
> https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py#newcode41
> PRESUBMIT.py:41: 'webrtc/api/video_decoder.h',
> On 2017/03/30 08:10:36, the sun wrote:
> > 1. List should be sorted.
> > 2. Move the files to webrtc/api/video_codec/ instead (that matches the
> structure
> > for audio).
> 
> Done.

Solenberg@, should I also move a GN target to /api/video_codec/BUILD.gn from
/api/BUILD.gn?

[the sun, 2017-03-31 06:31:32]

On 2017/03/30 14:48:12, ilnik wrote:
> On 2017/03/30 11:15:57, ilnik wrote:
> > https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py
> > File PRESUBMIT.py (right):
> > 
> > https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py#newcode41
> > PRESUBMIT.py:41: 'webrtc/api/video_decoder.h',
> > On 2017/03/30 08:10:36, the sun wrote:
> > > 1. List should be sorted.
> > > 2. Move the files to webrtc/api/video_codec/ instead (that matches the
> > structure
> > > for audio).
> > 
> > Done.
> 
> Solenberg@, should I also move a GN target to /api/video_codec/BUILD.gn from
> /api/BUILD.gn?

Yes, I think it makes sense to copy the build target structure as well - one
target including both enc/dec (and in the future, factories).

[ilnik, 2017-03-31 07:45:11]

On 2017/03/31 06:31:32, the sun wrote:
> On 2017/03/30 14:48:12, ilnik wrote:
> > On 2017/03/30 11:15:57, ilnik wrote:
> > > https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py
> > > File PRESUBMIT.py (right):
> > > 
> > > https://codereview.webrtc.org/2780943003/diff/40001/PRESUBMIT.py#newcode41
> > > PRESUBMIT.py:41: 'webrtc/api/video_decoder.h',
> > > On 2017/03/30 08:10:36, the sun wrote:
> > > > 1. List should be sorted.
> > > > 2. Move the files to webrtc/api/video_codec/ instead (that matches the
> > > structure
> > > > for audio).
> > > 
> > > Done.
> > 
> > Solenberg@, should I also move a GN target to /api/video_codec/BUILD.gn from
> > /api/BUILD.gn?
> 
> Yes, I think it makes sense to copy the build target structure as well - one
> target including both enc/dec (and in the future, factories).

Done.

[ilnik, 2017-03-31 07:48:37]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 07:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[the sun, 2017-03-31 08:10:27]

Looks good, but include order is off in most cpp files.

https://codereview.webrtc.org/2780943003/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.webrtc.org/2780943003/diff/100001/PRESUBMIT.py#oldcode1
PRESUBMIT.py:1: # Copyright (c) 2012 The WebRTC project authors. All Rights
Reserved.
Can you update webrtc/DEPS as well?

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/fake...
File webrtc/media/engine/fakewebrtcvideoengine.h (right):

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/fake...
webrtc/media/engine/fakewebrtcvideoengine.h:28: #include
"webrtc/api/video_codecs/video_decoder.h"
order

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/vide...
File webrtc/media/engine/videoencodersoftwarefallbackwrapper.h (right):

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/vide...
webrtc/media/engine/videoencodersoftwarefallbackwrapper.h:19: #include
"webrtc/api/video_codecs/video_encoder.h"
order

[commit-bot: I haz the power, 2017-03-31 08:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 08:10:29]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-04-03 07:42:36]

https://codereview.webrtc.org/2780943003/diff/100001/PRESUBMIT.py
File PRESUBMIT.py (left):

https://codereview.webrtc.org/2780943003/diff/100001/PRESUBMIT.py#oldcode1
PRESUBMIT.py:1: # Copyright (c) 2012 The WebRTC project authors. All Rights
Reserved.
On 2017/03/31 08:10:26, the sun wrote:
> Can you update webrtc/DEPS as well?

Done.

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/fake...
File webrtc/media/engine/fakewebrtcvideoengine.h (right):

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/fake...
webrtc/media/engine/fakewebrtcvideoengine.h:28: #include
"webrtc/api/video_codecs/video_decoder.h"
On 2017/03/31 08:10:26, the sun wrote:
> order

Done.

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/vide...
File webrtc/media/engine/videoencodersoftwarefallbackwrapper.h (right):

https://codereview.webrtc.org/2780943003/diff/100001/webrtc/media/engine/vide...
webrtc/media/engine/videoencodersoftwarefallbackwrapper.h:19: #include
"webrtc/api/video_codecs/video_encoder.h"
On 2017/03/31 08:10:26, the sun wrote:
> order

Done.

[the sun, 2017-04-03 14:48:30]

lgtm

https://codereview.webrtc.org/2780943003/diff/120001/webrtc/sdk/android/src/j...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2780943003/diff/120001/webrtc/sdk/android/src/j...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:556: picture_id_ =
static_cast<uint16_t>(rand()) & 0x7FFF;  // NOLINT
What's the warning? Should there be a TODO()?

[ilnik, 2017-04-03 14:58:22]

https://codereview.webrtc.org/2780943003/diff/120001/webrtc/sdk/android/src/j...
File webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc (right):

https://codereview.webrtc.org/2780943003/diff/120001/webrtc/sdk/android/src/j...
webrtc/sdk/android/src/jni/androidmediaencoder_jni.cc:556: picture_id_ =
static_cast<uint16_t>(rand()) & 0x7FFF;  // NOLINT
On 2017/04/03 14:48:30, the sun wrote:
> What's the warning? Should there be a TODO()?

Don't use rand(), user rand_r() instead.
Requires some seed. Since I don't know what are the intentions here, I can't
change it. But you are right, I should've put a TODO here.

[ilnik, 2017-04-03 15:01:02]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-03 15:01:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 15:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-03 15:26:32]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-04-03 15:37:13]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-04-03 15:37:13]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2780943003/#ps140001 (title:
"Add missing TODO")

[commit-bot: I haz the power, 2017-04-03 15:37:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-03 15:37:32]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491233833106380,
"parent_rev": "eb4662a64d8d88cda0e1606817f36f166122492b", "commit_rev":
"c42f54057050c933008a49d57582577bfb9aed25"}

[commit-bot: I haz the power, 2017-04-03 15:37:35]

Description was changed from

==========
Move video_encoder.h and video_decoder.h to /api and create GN targets for them

BUG=webrtc:5881
# Because PRESUBMIT ignores LINT blacklist for moved files and these 
# headers have some not easy to resolve issues.
NOPRESUBMIT=True
==========

to

==========
Move video_encoder.h and video_decoder.h to /api and create GN targets for them

BUG=webrtc:5881
# Because PRESUBMIT ignores LINT blacklist for moved files and these 
# headers have some not easy to resolve issues.
NOPRESUBMIT=True

Review-Url: https://codereview.webrtc.org/2780943003
Cr-Commit-Position: refs/heads/master@{#17511}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...
==========

[commit-bot: I haz the power, 2017-04-03 15:37:37]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/c42f54057050c933008a49d57...

[guidou, 2017-04-03 16:15:35]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.webrtc.org/2794033002/ by guidou@webrtc.org.

The reason for reverting is: Suspect of breaking Chrome FYI bots.

See
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Builder

Example logs:
../../content/renderer/media/gpu/rtc_video_encoder_unittest.cc:18:46: fatal
error: third_party/webrtc/video_encoder.h: No such file or directory
 #include "third_party/webrtc/video_encoder.h"
                                              ^.