Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2786993003: Reland: Use native (optimized) functions for byte order conversion. (Closed)

Created:
3 years, 8 months ago by joachim
Modified:
3 years, 8 months ago
Reviewers:
tommi, kthelgason, mbonadei
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland: Use native (optimized) functions for byte order conversion. (patchset #1 id:1 of https://codereview.webrtc.org/2755103002/ ) Reason for revert: The problem with the internal project has been solved according to mbonadei@ Original issue's description: > Revert of Reland: Use native (optimized) functions for byte order conversion. (patchset #5 id:80001 of https://codereview.webrtc.org/2751403003/ ) > > Reason for revert: > Breaks internal project. > > Original issue's description: > > Reland: Use native (optimized) functions for byte order conversion. > > > > Instead of manually copying single bytes, the native functions like "htobe32" > > are used. > > > > The previous CL https://codereview.webrtc.org/2738063005/ got reverted in > > https://codereview.webrtc.org/2757703002/ > > > > Reland with the compilation errors fixed. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/2751403003 > > Cr-Commit-Position: refs/heads/master@{#17280} > > Committed: https://chromium.googlesource.com/external/webrtc/+/c8a4c1f24ca3a2ececeb1b3774e1fc80f8ffe631 > > TBR=tommi@webrtc.org,jbauch@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/2755103002 > Cr-Commit-Position: refs/heads/master@{#17282} > Committed: https://chromium.googlesource.com/external/webrtc/+/44122bd0f96b30983091f5be26b57e45f6cc9e33 TBR=tommi@webrtc.org,kthelgason@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/2786993003 Cr-Commit-Position: refs/heads/master@{#17479} Committed: https://chromium.googlesource.com/external/webrtc/+/5533bd36fed28fbb62ce5c09923605bf5e0f94d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -71 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/byteorder.h View 2 chunks +83 lines, -71 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
joachim
Created Reland of land: Use native (optimized) functions for byte order conversion.
3 years, 8 months ago (2017-03-30 22:07:12 UTC) #1
joachim
Ptal, not sure if I need another l-g-t-m
3 years, 8 months ago (2017-03-30 22:09:36 UTC) #4
tommi
lgtm
3 years, 8 months ago (2017-03-31 08:39:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2786993003/1
3 years, 8 months ago (2017-03-31 08:39:37 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 08:42:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5533bd36fed28fbb62ce5c099...

Powered by Google App Engine
This is Rietveld 408576698