Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2755103002: Revert of Reland: Use native (optimized) functions for byte order conversion. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
Reviewers:
tommi, joachim
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Reland: Use native (optimized) functions for byte order conversion. (patchset #5 id:80001 of https://codereview.webrtc.org/2751403003/ ) Reason for revert: Breaks internal project. Original issue's description: > Reland: Use native (optimized) functions for byte order conversion. > > Instead of manually copying single bytes, the native functions like "htobe32" > are used. > > The previous CL https://codereview.webrtc.org/2738063005/ got reverted in > https://codereview.webrtc.org/2757703002/ > > Reland with the compilation errors fixed. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2751403003 > Cr-Commit-Position: refs/heads/master@{#17280} > Committed: https://chromium.googlesource.com/external/webrtc/+/c8a4c1f24ca3a2ececeb1b3774e1fc80f8ffe631 TBR=tommi@webrtc.org,jbauch@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2755103002 Cr-Commit-Position: refs/heads/master@{#17282} Committed: https://chromium.googlesource.com/external/webrtc/+/44122bd0f96b30983091f5be26b57e45f6cc9e33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -86 lines) Patch
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/base/byteorder.h View 2 chunks +71 lines, -83 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kthelgason
Created Revert of Reland: Use native (optimized) functions for byte order conversion.
3 years, 9 months ago (2017-03-17 09:28:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2755103002/1
3 years, 9 months ago (2017-03-17 09:28:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/44122bd0f96b30983091f5be26b57e45f6cc9e33
3 years, 9 months ago (2017-03-17 09:28:31 UTC) #6
joachim
3 years, 8 months ago (2017-03-30 22:07:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2786993003/ by jbauch@webrtc.org.

The reason for reverting is: The problem with the internal project has been
solved according to mbonadei@.

Powered by Google App Engine
This is Rietveld 408576698