Reland: Use native (optimized) functions for byte order conversion.

Reland: Use native (optimized) functions for byte order conversion.

Instead of manually copying single bytes, the native functions like "htobe32"
are used.

The previous CL https://codereview.webrtc.org/2738063005/ got reverted in
https://codereview.webrtc.org/2757703002/

Reland with the compilation errors fixed.

BUG=None

Review-Url: https://codereview.webrtc.org/2751403003
Cr-Commit-Position: refs/heads/master@{#17280}
Committed: https://chromium.googlesource.com/external/webrtc/+/c8a4c1f24ca3a2ececeb1b3774e1fc80f8ffe631

[joachim, 2017-03-17 00:10:18]

jbauch@webrtc.org changed reviewers:
+ tommi@webrtc.org

[joachim, 2017-03-17 00:10:18]

Ptal, I verified the fixes with some Chromium trybots (and hope that covered
all).

https://codereview.webrtc.org/2751403003/diff/80001/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2751403003/diff/80001/webrtc/base/BUILD.gn#newc...
webrtc/base/BUILD.gn:275: deps += [ "//native_client_sdk/src/libraries/nacl_io"
]
This is required for including "netinet/in.h" in the native client case (to get
htons, etc).

[tommi, 2017-03-17 05:26:33]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2017-03-17 05:26:33]

lgtm

[commit-bot: I haz the power, 2017-03-17 05:26:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 05:49:51]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489728393166760,
"parent_rev": "946b0dd1f076d92cb622fb8b73aed84a09f0dde9", "commit_rev":
"c8a4c1f24ca3a2ececeb1b3774e1fc80f8ffe631"}

[commit-bot: I haz the power, 2017-03-17 05:49:54]

Description was changed from

==========
Reland: Use native (optimized) functions for byte order conversion.

Instead of manually copying single bytes, the native functions like "htobe32"
are used.

The previous CL https://codereview.webrtc.org/2738063005/ got reverted in
https://codereview.webrtc.org/2757703002/

Reland with the compilation errors fixed.

BUG=None
==========

to

==========
Reland: Use native (optimized) functions for byte order conversion.

Instead of manually copying single bytes, the native functions like "htobe32"
are used.

The previous CL https://codereview.webrtc.org/2738063005/ got reverted in
https://codereview.webrtc.org/2757703002/

Reland with the compilation errors fixed.

BUG=None

Review-Url: https://codereview.webrtc.org/2751403003
Cr-Commit-Position: refs/heads/master@{#17280}
Committed:
https://chromium.googlesource.com/external/webrtc/+/c8a4c1f24ca3a2ececeb1b377...
==========

[commit-bot: I haz the power, 2017-03-17 05:49:55]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/c8a4c1f24ca3a2ececeb1b377...

[kthelgason, 2017-03-17 09:28:12]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.webrtc.org/2755103002/ by kthelgason@webrtc.org.

The reason for reverting is: Breaks internal project..

[mbonadei, 2017-03-30 17:59:54]

On 2017/03/17 09:28:12, kthelgason wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.webrtc.org/2755103002/ by mailto:kthelgason@webrtc.org.
> 
> The reason for reverting is: Breaks internal project..

Hi, we have solved the problem. This CL can now be landed.

[joachim, 2017-03-30 22:11:03]

On 2017/03/30 17:59:54, mbonadei wrote:
> On 2017/03/17 09:28:12, kthelgason wrote:
> > A revert of this CL (patchset #5 id:80001) has been created in
> > https://codereview.webrtc.org/2755103002/ by mailto:kthelgason@webrtc.org.
> > 
> > The reason for reverting is: Breaks internal project..
> 
> Hi, we have solved the problem. This CL can now be landed.

Thanks, the CL to reland is https://codereview.webrtc.org/2786993003/