Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2776083002: enable fallback path (Closed)

Created:
3 years, 9 months ago by qiankun
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, Stephen Chennney, dshwang, jam, jbroman, fmalita+watch_chromium.org, blink-reviews, Rik, darin-cc_chromium.org, Justin Novosad, pdr+graphicswatchlist_chromium.org, haraken, piman+watch_chromium.org, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

enable fallback path Add readback path for CopyTextureCHROMIUM There are some liminations or driver bugs which cause GPU-GPU copy unavailable in CopyTextureCHROMIUM. For such cases, we do a readback fallback, i.e. draw the source texture to an intermediate texture in RGBA format, read back pixels of the intermediate texture from GPU to CPU, then upload pixels to destination texture with TexImage api. With this approach, the caller of glCopyTextureCHROMIUM doesn't need to care about the liminations and bugs mentioned above. BUG=612542 fix Y16 video texture fix comments#4 Enable CopyTextureCHROMIUM in Blink for Tex{Sub}Image2D with more cases BUG=612542 TEST=webgl and webgl2 conformance tests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : use pack/unpack buffer #

Patch Set 3 : print formats and remove non-es-path #

Patch Set 4 : reset pack and unpack buffer #

Patch Set 5 : read to client memory #

Patch Set 6 : remove mapbufferrange #

Patch Set 7 : read to client memory and upload with bufferData #

Patch Set 8 : read to pbo and upload with bufferData instead of mapBufferRange #

Patch Set 9 : mix read to pbo and read to client memory #

Patch Set 10 : remove map buffer for readPixel #

Patch Set 11 : remove readpixels #

Patch Set 12 : print pixels #

Patch Set 13 : use stream read #

Unified diffs Side-by-side diffs Delta from patch set Stats (+396 lines, -288 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 3 chunks +22 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 2 chunks +6 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +206 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +30 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 17 chunks +81 lines, -156 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp View 2 chunks +9 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.h View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp View 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 41 (41 generated)
qiankun
Description was changed from ========== enable fallback path Add readback path for CopyTextureCHROMIUM There are ...
3 years, 9 months ago (2017-03-27 02:24:21 UTC) #1
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 02:27:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/1
3 years, 9 months ago (2017-03-27 02:27:25 UTC) #3
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 03:22:19 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/20001
3 years, 9 months ago (2017-03-27 03:22:27 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-27 03:45:03 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/194534)
3 years, 9 months ago (2017-03-27 03:45:04 UTC) #7
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 05:27:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/40001
3 years, 9 months ago (2017-03-27 05:27:14 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-27 06:05:15 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/8146)
3 years, 9 months ago (2017-03-27 06:05:16 UTC) #11
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 06:29:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/60001
3 years, 9 months ago (2017-03-27 06:29:53 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-27 07:08:18 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/144223) linux_optional_gpu_tests_rel on ...
3 years, 9 months ago (2017-03-27 07:08:19 UTC) #15
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 07:53:55 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/80001
3 years, 9 months ago (2017-03-27 07:54:05 UTC) #17
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 08:07:19 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/100001
3 years, 9 months ago (2017-03-27 08:07:38 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-27 08:45:53 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/391707) linux_optional_gpu_tests_rel on ...
3 years, 9 months ago (2017-03-27 08:45:54 UTC) #21
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 09:25:00 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/120001
3 years, 9 months ago (2017-03-27 09:25:15 UTC) #23
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-27 09:35:10 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/140001
3 years, 9 months ago (2017-03-27 09:35:27 UTC) #25
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-27 10:30:14 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_optional_gpu_tests_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/3241)
3 years, 9 months ago (2017-03-27 10:30:15 UTC) #27
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-28 02:09:01 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/160001
3 years, 9 months ago (2017-03-28 02:09:25 UTC) #29
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-28 02:20:16 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/180001
3 years, 9 months ago (2017-03-28 02:20:33 UTC) #31
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-28 03:18:50 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/200001
3 years, 9 months ago (2017-03-28 03:19:10 UTC) #33
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 9 months ago (2017-03-28 03:27:58 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/220001
3 years, 9 months ago (2017-03-28 03:28:28 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-28 04:42:59 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/8368)
3 years, 8 months ago (2017-03-28 04:43:01 UTC) #37
qiankun
The CQ bit was checked by qiankun.miao@intel.com to run a CQ dry run
3 years, 8 months ago (2017-03-28 08:43:12 UTC) #38
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2776083002/240001
3 years, 8 months ago (2017-03-28 08:43:32 UTC) #39
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-28 09:36:23 UTC) #40
commit-bot: I haz the power
3 years, 8 months ago (2017-03-28 09:36:24 UTC) #41
Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698