Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h

Issue 2776083002: enable fallback path (Closed)
Patch Set: use stream read Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
diff --git a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
index 93cdc58c7262cfbf93417326aff36e3f8fd066a3..9cad28bbd3cafe757ccc13e981b55e3a881120f0 100644
--- a/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
+++ b/gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h
@@ -25,6 +25,10 @@ enum CopyTextureMethod {
DIRECT_DRAW,
// Draw to an intermediate texture, and then copy to the destination texture.
DRAW_AND_COPY,
+ // Draw to an intermediate texture in RGBA format, read back pixels in the
+ // intermediate texture from GPU to CPU, and then upload to the destination
+ // texture.
+ DRAW_AND_READBACK,
// CopyTexture isn't available.
NOT_COPYABLE
};
@@ -32,13 +36,8 @@ enum CopyTextureMethod {
// TODOs(qiankun.miao@intel.com):
// 1. Add readback path for RGB9_E5 and float formats (if extension isn't
// available and they are not color-renderable).
-// 2. Support faces of cube map texture as valid dest target. The cube map
-// texture may be incomplete currently.
-// 3. Add support for levels other than 0.
-// 4. Support ALPHA, LUMINANCE and LUMINANCE_ALPHA formats on core profile.
-// 5. Update the extension doc after the whole work is done
-// in gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt. We probably
-// will need a ES2 version and a ES3 version.
+// 2. Support GL_TEXTURE_3D as valid dest_target.
+// 3. Support ALPHA, LUMINANCE and LUMINANCE_ALPHA formats on core profile.
// This class encapsulates the resources required to implement the
// GL_CHROMIUM_copy_texture extension. The copy operation is performed

Powered by Google App Engine
This is Rietveld 408576698