Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2766063005: Revert of Removing HTTPS and SOCKS proxy server code. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Removing HTTPS and SOCKS proxy server code. (patchset #2 id:20001 of https://codereview.webrtc.org/2731673002/ ) Also needed to revert these CLs, which removed code used by the code being un-removed: https://codereview.webrtc.org/2745523004 https://codereview.webrtc.org/2754033003 https://codereview.webrtc.org/2758943002 Reason for revert: This code is still being used by native application developers, so we should send a PSA announcing the deprecation and suggest an alternative before removing it. Original issue's description: > Removing HTTPS and SOCKS proxy server code. > > This isn't used any more so there's no point in maintaining it. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2731673002 > Cr-Commit-Position: refs/heads/master@{#17016} > Committed: https://chromium.googlesource.com/external/webrtc/+/a1991c517598fda9c9c0cf8876886e3968436ff9 TBR=pthatcher@webrtc.org NOPRESUBMIT=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2766063005 Cr-Commit-Position: refs/heads/master@{#17369} Committed: https://chromium.googlesource.com/external/webrtc/+/f137e97adbc00895c6485fb8ddee407312d0d775

Patch Set 1 #

Patch Set 2 : Reverting a couple other cleanup CLs that were made on top of this one... #

Patch Set 3 : Revert "Remove obsolete valgrind/MSAN suppressions." #

Patch Set 4 : Add comment about set_proxy being deprecated. #

Patch Set 5 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5454 lines, -36 lines) Patch
M tools-webrtc/sanitizers/lsan_suppressions_webrtc.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tools-webrtc/valgrind/memcheck/suppressions.txt View 1 2 4 chunks +31 lines, -1 line 0 comments Download
M webrtc/base/BUILD.gn View 1 6 chunks +14 lines, -0 lines 0 comments Download
A webrtc/base/cryptstring.h View 1 1 chunk +167 lines, -0 lines 0 comments Download
A webrtc/base/cryptstring.cc View 1 1 chunk +75 lines, -0 lines 0 comments Download
A webrtc/base/httpbase.h View 1 chunk +187 lines, -0 lines 0 comments Download
A webrtc/base/httpbase.cc View 1 chunk +886 lines, -0 lines 0 comments Download
A webrtc/base/httpbase_unittest.cc View 1 chunk +526 lines, -0 lines 0 comments Download
A webrtc/base/httpcommon.h View 1 chunk +458 lines, -0 lines 0 comments Download
A webrtc/base/httpcommon.cc View 1 chunk +1009 lines, -0 lines 0 comments Download
A webrtc/base/httpcommon-inl.h View 1 chunk +132 lines, -0 lines 0 comments Download
A webrtc/base/httpcommon_unittest.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A webrtc/base/httpserver.h View 1 chunk +139 lines, -0 lines 0 comments Download
A webrtc/base/httpserver.cc View 1 chunk +288 lines, -0 lines 0 comments Download
A webrtc/base/httpserver_unittest.cc View 1 chunk +130 lines, -0 lines 0 comments Download
A webrtc/base/proxy_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M webrtc/base/proxyinfo.h View 1 chunk +18 lines, -2 lines 0 comments Download
A + webrtc/base/proxyinfo.cc View 1 1 chunk +8 lines, -11 lines 0 comments Download
M webrtc/base/proxyserver.h View 1 1 chunk +12 lines, -0 lines 0 comments Download
M webrtc/base/proxyserver.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/socketadapters.h View 1 2 chunks +110 lines, -0 lines 0 comments Download
M webrtc/base/socketadapters.cc View 1 2 chunks +604 lines, -0 lines 0 comments Download
M webrtc/base/stream.h View 1 4 chunks +135 lines, -0 lines 0 comments Download
M webrtc/base/stream.cc View 1 4 chunks +158 lines, -0 lines 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 1 11 chunks +82 lines, -20 lines 0 comments Download
M webrtc/p2p/base/packetsocketfactory.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/p2p/base/portallocator.h View 1 2 3 3 chunks +13 lines, -0 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
Taylor Brandstetter
Created Revert of Removing HTTPS and SOCKS proxy server code.
3 years, 9 months ago (2017-03-22 04:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2766063005/1
3 years, 9 months ago (2017-03-22 04:50:19 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/2777) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 9 months ago (2017-03-22 04:52:49 UTC) #5
Taylor Brandstetter
FYI nisse, kthelgason, I had to revert your CLs as well...
3 years, 9 months ago (2017-03-23 01:04:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2766063005/280001
3 years, 9 months ago (2017-03-23 01:04:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/15259)
3 years, 9 months ago (2017-03-23 01:10:07 UTC) #12
Taylor Brandstetter
Also had to revert https://codereview.webrtc.org/2758943002...
3 years, 9 months ago (2017-03-23 04:11:12 UTC) #15
nisse-webrtc
What schedule do you aim for with PSA and removal?
3 years, 9 months ago (2017-03-23 07:29:42 UTC) #16
nisse-webrtc
lgtm Can you add deprecation comments in the header files for features you add back? ...
3 years, 9 months ago (2017-03-23 07:49:39 UTC) #17
the sun
On 2017/03/23 07:49:39, nisse-webrtc wrote: > lgtm > > Can you add deprecation comments in ...
3 years, 9 months ago (2017-03-23 11:12:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2766063005/340001
3 years, 9 months ago (2017-03-23 22:45:37 UTC) #26
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 22:45:55 UTC) #29
Message was sent while issue was closed.
Committed patchset #5 (id:340001) as
https://chromium.googlesource.com/external/webrtc/+/f137e97adbc00895c6485fb8d...

Powered by Google App Engine
This is Rietveld 408576698