Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2731673002: Removing HTTPS and SOCKS proxy server code. (Closed)

Created:
3 years, 9 months ago by Taylor Brandstetter
Modified:
3 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing HTTPS and SOCKS proxy server code. This isn't used any more so there's no point in maintaining it. BUG=None Review-Url: https://codereview.webrtc.org/2731673002 Cr-Commit-Position: refs/heads/master@{#17016} Committed: https://chromium.googlesource.com/external/webrtc/+/a1991c517598fda9c9c0cf8876886e3968436ff9

Patch Set 1 #

Patch Set 2 : Adding back something still referenced by chromium. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4892 lines) Patch
M webrtc/base/BUILD.gn View 5 chunks +0 lines, -12 lines 0 comments Download
D webrtc/base/httpbase.h View 1 chunk +0 lines, -187 lines 0 comments Download
D webrtc/base/httpbase.cc View 1 chunk +0 lines, -886 lines 0 comments Download
D webrtc/base/httpbase_unittest.cc View 1 chunk +0 lines, -526 lines 0 comments Download
D webrtc/base/httpcommon.h View 1 chunk +0 lines, -458 lines 0 comments Download
D webrtc/base/httpcommon.cc View 1 chunk +0 lines, -1009 lines 0 comments Download
D webrtc/base/httpcommon-inl.h View 1 chunk +0 lines, -132 lines 0 comments Download
D webrtc/base/httpcommon_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D webrtc/base/httpserver.h View 1 chunk +0 lines, -139 lines 0 comments Download
D webrtc/base/httpserver.cc View 1 chunk +0 lines, -288 lines 0 comments Download
D webrtc/base/httpserver_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D webrtc/base/proxy_unittest.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M webrtc/base/proxyinfo.h View 1 1 chunk +2 lines, -18 lines 0 comments Download
D webrtc/base/proxyinfo.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M webrtc/base/proxyserver.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/base/proxyserver.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/socketadapters.h View 2 chunks +0 lines, -109 lines 0 comments Download
M webrtc/base/socketadapters.cc View 2 chunks +0 lines, -604 lines 0 comments Download
M webrtc/p2p/base/basicpacketsocketfactory.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 11 chunks +20 lines, -82 lines 0 comments Download
M webrtc/p2p/base/packetsocketfactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/portallocator.h View 3 chunks +0 lines, -10 lines 0 comments Download
M webrtc/p2p/base/relayport.cc View 1 chunk +1 line, -9 lines 0 comments Download
M webrtc/p2p/client/basicportallocator.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Taylor Brandstetter
3 years, 9 months ago (2017-03-03 06:10:09 UTC) #6
pthatcher1
lgtm Wow, that was a lot.
3 years, 9 months ago (2017-03-03 06:37:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2731673002/20001
3 years, 9 months ago (2017-03-03 18:02:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/a1991c517598fda9c9c0cf8876886e3968436ff9
3 years, 9 months ago (2017-03-03 18:23:13 UTC) #12
nisse-webrtc
Great! When did this code become unused? When I deleted httpclient a few weeks ago, ...
3 years, 9 months ago (2017-03-08 12:36:08 UTC) #13
Taylor Brandstetter
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.webrtc.org/2766063005/ by deadbeef@webrtc.org. ...
3 years, 9 months ago (2017-03-22 04:50:12 UTC) #14
juberti1
3 years, 6 months ago (2017-06-01 22:18:57 UTC) #15
Message was sent while issue was closed.
On 2017/03/22 04:50:12, Taylor Brandstetter wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.webrtc.org/2766063005/ by mailto:deadbeef@webrtc.org.
> 
> The reason for reverting is: This code is still being used by native
application
> developers, so we should send a PSA announcing the deprecation and suggest an
> alternative before removing it..

Seems like this could be necessary for Duo, and almost certainly necessary for
Meet. Why do we want to remove this?

Powered by Google App Engine
This is Rietveld 408576698