Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2762963002: Make lint errors fatal in presubmit and fix files in whitelisted paths (Closed)

Created:
3 years, 9 months ago by oprypin_webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make lint errors fatal in presubmit and fix files in whitelisted paths BUG=webrtc:5149 Review-Url: https://codereview.webrtc.org/2762963002 Cr-Commit-Position: refs/heads/master@{#17323} Committed: https://chromium.googlesource.com/external/webrtc/+/8e58d65ddfa14a0ab13f656bef6424b1f3a4796b

Patch Set 1 : Fix lint errors in whitelisted locations #

Patch Set 2 : Fix string concat #

Patch Set 3 : Make lint errors fatal in presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M PRESUBMIT.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/api/rtcerror.h View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/bwe_simulations.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/mock/mock_packet_manipulator.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
oprypin_webrtc
3 years, 9 months ago (2017-03-21 14:31:54 UTC) #11
kjellander_webrtc
lgtm
3 years, 9 months ago (2017-03-21 14:37:19 UTC) #12
henrika_webrtc
lgtm
3 years, 9 months ago (2017-03-21 14:47:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2762963002/80001
3 years, 9 months ago (2017-03-21 14:50:05 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 14:52:45 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8e58d65ddfa14a0ab13f656be...

Powered by Google App Engine
This is Rietveld 408576698