PRESUBMIT.py - Issue 2762963002: Make lint errors fatal in presubmit and fix files in whitelisted paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 2762963002: Make lint errors fatal in presubmit and fix files in whitelisted paths (Closed)

Patch Set: Make lint errors fatal in presubmit Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 72e4326fe4f2e9a3784156695aed3063dcc6a49f..03a77b28681d9df9e72559a4d71c3418159661dc 100755

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -255,9 +255,7 @@ def _CheckApprovedFilesLintClean(input_api, output_api,

if cpplint._cpplint_state.error_count > 0:

if input_api.is_committing:

- # TODO(kjellander): Change back to PresubmitError below when we're

- # confident with the lint settings.

- res_type = output_api.PresubmitPromptWarning

+ res_type = output_api.PresubmitError

else:

res_type = output_api.PresubmitPromptWarning

result = [res_type('Changelist failed cpplint.py check.')]

« no previous file with comments | « no previous file | webrtc/api/rtcerror.h » ('j') | no next file with comments »