Make lint errors fatal in presubmit and fix files in whitelisted paths

webrtc/api/rtcerror.h

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 185 matching lines @@
   template <typename U>
   friend class RTCErrorOr;
 
  public:
   typedef T element_type;
 
   // Constructs a new RTCErrorOr with RTCErrorType::INTERNAL_ERROR error. This
   // is marked 'explicit' to try to catch cases like 'return {};', where people
   // think RTCErrorOr<std::vector<int>> will be initialized with an empty
   // vector, instead of a RTCErrorType::INTERNAL_ERROR error.
-  explicit RTCErrorOr() : error_(RTCErrorType::INTERNAL_ERROR) {}
+  RTCErrorOr() : error_(RTCErrorType::INTERNAL_ERROR) {}
 
   // Constructs a new RTCErrorOr with the given non-ok error. After calling
   // this constructor, calls to value() will DCHECK-fail.
   //
   // NOTE: Not explicit - we want to use RTCErrorOr<T> as a return
   // value, so it is convenient and sensible to be able to do 'return
   // RTCError(...)' when the return type is RTCErrorOr<T>.
   //
   // REQUIRES: !error.ok(). This requirement is DCHECKed.
-  RTCErrorOr(RTCError&& error) : error_(std::move(error)) {
+  RTCErrorOr(RTCError&& error) : error_(std::move(error)) {  // NOLINT
     RTC_DCHECK(!error.ok());
   }
 
   // Constructs a new RTCErrorOr with the given value. After calling this
   // constructor, calls to value() will succeed, and calls to error() will
   // return a default-constructed RTCError.
   //
   // NOTE: Not explicit - we want to use RTCErrorOr<T> as a return type
   // so it is convenient and sensible to be able to do 'return T()'
   // when the return type is RTCErrorOr<T>.
-  RTCErrorOr(T&& value) : value_(std::move(value)) {}
+  RTCErrorOr(T&& value) : value_(std::move(value)) {}  // NOLINT
 
   // Delete the copy constructor and assignment operator; there aren't any use
   // cases where you should need to copy an RTCErrorOr, as opposed to moving
   // it. Can revisit this decision if use cases arise in the future.
   RTCErrorOr(const RTCErrorOr& other) = delete;
   RTCErrorOr& operator=(const RTCErrorOr& other) = delete;
 
   // Move constructor and move-assignment operator.
   //
   // Visual Studio doesn't support "= default" with move constructors or
   // assignment operators (even though they compile, they segfault), so define
   // them explicitly.
   RTCErrorOr(RTCErrorOr&& other)
       : error_(std::move(other.error_)), value_(std::move(other.value_)) {}
   RTCErrorOr& operator=(RTCErrorOr&& other) {
     error_ = std::move(other.error_);
     value_ = std::move(other.value_);
     return *this;
   }
 
   // Conversion constructor and assignment operator; T must be copy or move
   // constructible from U.
   template <typename U>
-  RTCErrorOr(RTCErrorOr<U> other)
+  RTCErrorOr(RTCErrorOr<U> other)  // NOLINT
       : error_(std::move(other.error_)), value_(std::move(other.value_)) {}
   template <typename U>
   RTCErrorOr& operator=(RTCErrorOr<U> other) {
     error_ = std::move(other.error_);
     value_ = std::move(other.value_);
     return *this;
   }
 
   // Returns a reference to our error. If this contains a T, then returns
   // default-constructed RTCError.
@@ skipping 29 matching lines @@
   }
 
  private:
   RTCError error_;
   T value_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_RTCERROR_H_