Reland "C++ porting of the initial python script for conversational speech generation."

Reland "C++ porting of the initial python script for conversational speech
generation."

This CL removes the Python script and adds its C++ porting.
The former was in its early stage and it has permanently been removed.

This is a reland of https://codereview.webrtc.org/2740063004/ which
was reverted. Now the build errors are fixed.

BUG=webrtc:7218
Review-Url: https://codereview.webrtc.org/2752793002
Cr-Commit-Position: refs/heads/master@{#17300}
Committed: https://chromium.googlesource.com/external/webrtc/+/5f32aca85ef6c2ded2ec89b4b2a49f62b151223a

[AleBzk, 2017-03-15 15:56:59]

The CQ bit was checked by alessiob@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 15:57:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-15 15:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:59:23]

Dry run: Try jobs failed on following builders:
  ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...)
  ios64_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios9_dbg/buil...)
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/18610)
  ios_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/23894)

[AleBzk, 2017-03-15 16:03:21]

Description was changed from

==========
Fix after revert of CL 2740063004 (conversational speech generator)

BUG=webrtc:7218
==========

to

==========
Fix after revert of CL 2740063004 (conversational speech generator)

BUG=webrtc:7218
==========

[AleBzk, 2017-03-15 16:03:21]

alessiob@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[AleBzk, 2017-03-15 16:45:04]

Patchset #2 (id:20001) has been deleted

[AleBzk, 2017-03-15 17:14:09]

Patchset #2 (id:40001) has been deleted

[kjellander (google.com), 2017-03-16 15:51:01]

On 2017/03/15 17:14:09, AleBzk wrote:
> Patchset #2 (id:40001) has been deleted

Can you make PS#1 be the same contents as the reverted CL and then make fixes in
PS#2 and so on?

[AleBzk, 2017-03-16 15:58:55]

On 2017/03/16 15:51:01, kjellander (google.com) wrote:
> On 2017/03/15 17:14:09, AleBzk wrote:
> > Patchset #2 (id:40001) has been deleted
> 
> Can you make PS#1 be the same contents as the reverted CL and then make fixes
in
> PS#2 and so on?

Already done, PS#1 comes from the reverted CL.
PS#2 will be uploaded to solve the issues with the ios*dbg trybots.

[kjellander (google.com), 2017-03-16 16:32:47]

kjellander@google.com changed reviewers:
+ kjellander@google.com

[kjellander (google.com), 2017-03-16 16:32:48]

I think the problem is due to //webrtc/test:fileutils.
See comment.

https://codereview.webrtc.org/2752793002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn
(right):

https://codereview.webrtc.org/2752793002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn:28:
"//webrtc/test:fileutils",
You're using #include "webrtc/test/testsupport/fileutils.h" but you're only
depending on //webrtc/test:fileutils. We created that target only for being able
to swap fileutils implementations for different build systems, so I don't think
it should be used.

What if you change this dependency to be //webrtc/test:test_support instead?

Edward: Can you make a CL to add visibility = [ ":*" ] to the
//webrtc/test:fileutils target so we can avoid similar mistakes in the future?

[AleBzk, 2017-03-17 06:03:59]

Patchset #2 (id:60001) has been deleted

[AleBzk, 2017-03-17 06:07:15]

Patchset #2 (id:80001) has been deleted

[AleBzk, 2017-03-17 09:58:19]

The CQ bit was checked by alessiob@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 09:58:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[AleBzk, 2017-03-17 10:15:29]

Thanks a lot, changing the dependency worked!
You can see the change in BUILD.gn.
Once I get lgtm, I will commit *without* NOTRY, even if I already tested with a
dry run.

[kjellander_webrtc, 2017-03-17 10:17:19]

On 2017/03/17 10:15:29, AleBzk wrote:
> Thanks a lot, changing the dependency worked!
> You can see the change in BUILD.gn.
> Once I get lgtm, I will commit *without* NOTRY, even if I already tested with
a
> dry run.

If you do a dry run, the same bots won't run unless the results are >24 hours
old. That's the point with the dry run (in addition to make it easy to run the
right set of bots before actually putting the CL into the CQ).

[kjellander_webrtc, 2017-03-17 10:22:22]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-03-17 10:22:24]

I'd prefer a CL description like this:
Reland "C++ porting of the initial python script for conversational speech
generation."

This CL removes the Python script and adds its C++ porting.
The former was in its early stage and it has permanently been removed.

This is a reland of https://codereview.webrtc.org/2740063004/ which
was reverted. Now the build errors are fixed.

BUG=webrtc:7218


A generic tip: For relanding CLs, you get a good template CL by reverting the
revert CL (https://codereview.webrtc.org/2753843002).
It will then contain all relevant information. Then you can add the additional
changes to the description.
Then just patch that into your local branch with git cl patch, do the local
changes and upload another patch set for reland-review.

[AleBzk, 2017-03-17 10:24:02]

Description was changed from

==========
Fix after revert of CL 2740063004 (conversational speech generator)

BUG=webrtc:7218
==========

to

==========
Reland "C++ porting of the initial python script for conversational speech
generation."

This CL removes the Python script and adds its C++ porting.
The former was in its early stage and it has permanently been removed.

This is a reland of https://codereview.webrtc.org/2740063004/ which
was reverted. Now the build errors are fixed.

BUG=webrtc:7218
==========

[AleBzk, 2017-03-17 10:25:39]

Done.

[kjellander_webrtc, 2017-03-17 10:38:43]

lgtm

[commit-bot: I haz the power, 2017-03-17 11:58:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 11:58:53]

Dry run: Try jobs failed on following builders:
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hlundin-webrtc, 2017-03-17 14:38:37]

lgtm

[AleBzk, 2017-03-18 09:26:29]

The CQ bit was checked by alessiob@webrtc.org

[commit-bot: I haz the power, 2017-03-18 09:26:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-18 09:29:13]

CQ is committing da patch.

Bot data: {"patchset_id": 90015, "attempt_start_ts": 1489829189148390,
"parent_rev": "7aeabd081f148e489d1e9d360c3fe7587a92b606", "commit_rev":
"5f32aca85ef6c2ded2ec89b4b2a49f62b151223a"}

[commit-bot: I haz the power, 2017-03-18 09:29:17]

Description was changed from

==========
Reland "C++ porting of the initial python script for conversational speech
generation."

This CL removes the Python script and adds its C++ porting.
The former was in its early stage and it has permanently been removed.

This is a reland of https://codereview.webrtc.org/2740063004/ which
was reverted. Now the build errors are fixed.

BUG=webrtc:7218
==========

to

==========
Reland "C++ porting of the initial python script for conversational speech
generation."

This CL removes the Python script and adds its C++ porting.
The former was in its early stage and it has permanently been removed.

This is a reland of https://codereview.webrtc.org/2740063004/ which
was reverted. Now the build errors are fixed.

BUG=webrtc:7218

Review-Url: https://codereview.webrtc.org/2752793002
Cr-Commit-Position: refs/heads/master@{#17300}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5f32aca85ef6c2ded2ec89b4b...
==========

[commit-bot: I haz the power, 2017-03-18 09:29:18]

Committed patchset #2 (id:90015) as
https://chromium.googlesource.com/external/webrtc/+/5f32aca85ef6c2ded2ec89b4b...