Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2753843002: Revert of C++ porting of the initial python script for conversational speech generation. (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of C++ porting of the initial python script for conversational speech generation. (patchset #2 id:100001 of https://codereview.webrtc.org/2740063004/ ) Reason for revert: Even if the conversational speech tool is external and not a core part of webrtc, there are too many trybots failing. Original issue's description: > C++ porting of the initial python script for conversational speech generation. > > This CL removes the Python script and adds its C++ porting. > The former was in its early stage and it has permanently been removed. > > BUG=webrtc:7218 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2740063004 > Cr-Commit-Position: refs/heads/master@{#17254} > Committed: https://chromium.googlesource.com/external/webrtc/+/0cf3aa6d0d170365a2dedb57960fbface736f851 TBR=henrik.lundin@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2753843002 Cr-Commit-Position: refs/heads/master@{#17257} Committed: https://chromium.googlesource.com/external/webrtc/+/dbbaa2ad66bd18429c5b4caf2436a61e276971f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -248 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn View 1 chunk +0 lines, -31 lines 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/README.md View 1 chunk +0 lines, -74 lines 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/settings.h View 1 chunk +0 lines, -39 lines 0 comments Download
D webrtc/modules/audio_processing/test/conversational_speech/settings.cc View 1 chunk +0 lines, -29 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/OWNERS View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/README.md View 1 chunk +74 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py View 1 chunk +58 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/py_conversational_speech/test_generation.py View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
AleBzk
Created Revert of C++ porting of the initial python script for conversational speech generation.
3 years, 9 months ago (2017-03-15 15:19:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2753843002/1
3 years, 9 months ago (2017-03-15 15:19:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/dbbaa2ad66bd18429c5b4caf2436a61e276971f9
3 years, 9 months ago (2017-03-15 15:19:29 UTC) #6
hlundin-webrtc
3 years, 9 months ago (2017-03-16 08:46:19 UTC) #7
Message was sent while issue was closed.
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698