Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2740063004: C++ porting of the initial python script for conversational speech generation. (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

C++ porting of the initial python script for conversational speech generation. This CL removes the Python script and adds its C++ porting. The former was in its early stage and it has permanently been removed. BUG=webrtc:7218 NOTRY=True Review-Url: https://codereview.webrtc.org/2740063004 Cr-Commit-Position: refs/heads/master@{#17254} Committed: https://chromium.googlesource.com/external/webrtc/+/0cf3aa6d0d170365a2dedb57960fbface736f851

Patch Set 1 #

Total comments: 26

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -161 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn View 1 1 chunk +31 lines, -0 lines 0 comments Download
A + webrtc/modules/audio_processing/test/conversational_speech/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + webrtc/modules/audio_processing/test/conversational_speech/README.md View 2 chunks +4 lines, -4 lines 0 comments Download
A webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/conversational_speech/settings.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A webrtc/modules/audio_processing/test/conversational_speech/settings.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_conversational_speech/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_conversational_speech/README.md View 1 chunk +0 lines, -74 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_conversational_speech/generate_conversational_tracks.py View 1 chunk +0 lines, -58 lines 0 comments Download
D webrtc/modules/audio_processing/test/py_conversational_speech/test_generation.py View 1 chunk +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 37 (25 generated)
AleBzk
Hi Henrik, As agreed, I switched to C++ for the conversation speech tool. Alessio
3 years, 9 months ago (2017-03-09 09:38:53 UTC) #3
hlundin-webrtc
Good start! See some comments inline. https://codereview.webrtc.org/2740063004/diff/1/webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc File webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc (right): https://codereview.webrtc.org/2740063004/diff/1/webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc#newcode41 webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc:41: if (!settings.ValidateAndReport()) { ...
3 years, 9 months ago (2017-03-13 12:28:20 UTC) #4
AleBzk
Hi Henrik, Thanks a lot for your comments. Everything has been addressed. Alessio https://codereview.webrtc.org/2740063004/diff/1/webrtc/modules/audio_processing/test/conversational_speech/convspeech_gen.cc File ...
3 years, 9 months ago (2017-03-13 14:14:42 UTC) #5
hlundin-webrtc
Very nice now! LGTM for webrtc/modules/audio_processing/ You will need an owner for the testsupport changes.
3 years, 9 months ago (2017-03-13 23:12:27 UTC) #6
AleBzk
I added H. Kjellander since he is an owner of //webrtc/test. I need his approval ...
3 years, 9 months ago (2017-03-14 07:57:56 UTC) #8
kjellander_webrtc
lgtm but please run the linux_internal trybot, since I suspect we might run into trouble ...
3 years, 9 months ago (2017-03-14 13:29:06 UTC) #9
AleBzk
https://codereview.webrtc.org/2740063004/diff/20001/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn File webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn (right): https://codereview.webrtc.org/2740063004/diff/20001/webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn#newcode16 webrtc/modules/audio_processing/test/conversational_speech/BUILD.gn:16: } # conversational_speech On 2017/03/14 13:29:06, kjellander_webrtc wrote: > ...
3 years, 9 months ago (2017-03-14 16:19:21 UTC) #10
AleBzk
For simplicity, I split this CL adding a new one. DirExists change is now in ...
3 years, 9 months ago (2017-03-15 14:52:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2740063004/100001
3 years, 9 months ago (2017-03-15 14:54:11 UTC) #32
commit-bot: I haz the power
Committed patchset #2 (id:100001) as https://chromium.googlesource.com/external/webrtc/+/0cf3aa6d0d170365a2dedb57960fbface736f851
3 years, 9 months ago (2017-03-15 14:56:31 UTC) #35
AleBzk
A revert of this CL (patchset #2 id:100001) has been created in https://codereview.webrtc.org/2753843002/ by alessiob@webrtc.org. ...
3 years, 9 months ago (2017-03-15 15:19:16 UTC) #36
kjellander_webrtc
3 years, 9 months ago (2017-03-16 15:49:58 UTC) #37
Message was sent while issue was closed.
On 2017/03/15 15:19:16, AleBzk wrote:
> A revert of this CL (patchset #2 id:100001) has been created in
> https://codereview.webrtc.org/2753843002/ by mailto:alessiob@webrtc.org.
> 
> The reason for reverting is: Even if the conversational speech tool is
external
> and not a core part of webrtc, there are too many trybots failing..

Please never use NOTRY=True unless you've manually run all relevant trybots or
you're absolutely sure your test doesn't need to run trybots. Our trybot
resources are not as scarce as they use to be, so feel free to use the CQ for
most CLs (but if you change like one line in an OWNERS file NOTRY=True is
certainly a saving). Better spend a few extra resources than breaking the tree
though.

Powered by Google App Engine
This is Rietveld 408576698