Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2749163003: FileUtilsTest DirExists function added (Closed)

Created:
3 years, 9 months ago by AleBzk
Modified:
3 years, 9 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

FileUtilsTest DirExists function added BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2749163003 Cr-Commit-Position: refs/heads/master@{#17247} Committed: https://chromium.googlesource.com/external/webrtc/+/e49fede158e9a8c9e8aeef06093a8d591331e9f7

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : unit test iOS profiling #

Patch Set 4 : test path changed #

Patch Set 5 : OS-generic test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M webrtc/test/testsupport/fileutils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/test/testsupport/fileutils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/test/testsupport/fileutils_unittest.cc View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (14 generated)
AleBzk
Hi Henrik, For simplicity, I've split https://codereview.webrtc.org/2740063004/ to isolate the change in //webrtc/test/testsupport from the ...
3 years, 9 months ago (2017-03-15 07:29:53 UTC) #5
kjellander_webrtc
lgtm but please run this through the regular CQ so all bots execute.
3 years, 9 months ago (2017-03-15 11:42:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2749163003/80001
3 years, 9 months ago (2017-03-15 13:02:25 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 13:05:03 UTC) #18
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/e49fede158e9a8c9e8aeef060...

Powered by Google App Engine
This is Rietveld 408576698