Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2743663002: Reland of Add unit tests for RTCMTLVideoView. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add unit tests for RTCMTLVideoView. (patchset #1 id:1 of https://codereview.webrtc.org/2733953006/ ) Reason for revert: Dependant CL has been relanded Original issue's description: > Revert of Add unit tests for RTCMTLVideoView. (patchset #6 id:100001 of https://codereview.webrtc.org/2723903003/ ) > > Reason for revert: > This CL depends on a reverted CL. > > Original issue's description: > > Add unit tests for RTCMTLVideoView. > > > > To properly test the functionality, following changes were needed > > - Make RTCMTLVideoView compiliable for all cpu architectures not just arm64. > > This is needed so that the test can run on any device and on simulator as well. > > - Refactor RTCMTLVideoView to have mockable class methods. > > The unittest class, RTCMTLVideoViewTests was designed to provide easy transition > > to XCTest when the time comes for that. > > To transition to XCTest it would suffice to inherit from XCTestCase and remove > > the gtest methods. > > > > BUG=webrtc:7079 > > > > Review-Url: https://codereview.webrtc.org/2723903003 > > Cr-Commit-Position: refs/heads/master@{#17014} > > Committed: https://chromium.googlesource.com/external/webrtc/+/0ebe0199acd1070f17ca2abc5bc22fdd8b0861ca > > TBR=magjed@webrtc.org,denicija@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2733953006 > Cr-Commit-Position: refs/heads/master@{#17118} > Committed: https://chromium.googlesource.com/external/webrtc/+/96d91524fa66b9a2e4f9fbbbc9c5e5149021a3f0 TBR=magjed@webrtc.org,denicija@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2743663002 Cr-Commit-Position: refs/heads/master@{#17140} Committed: https://chromium.googlesource.com/external/webrtc/+/954d9b943bff1c0ed834903a973f67ee1842b04a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -24 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h View 2 chunks +9 lines, -7 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 4 chunks +44 lines, -17 lines 0 comments Download
A webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm View 1 chunk +168 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kthelgason
Created Reland of Add unit tests for RTCMTLVideoView.
3 years, 9 months ago (2017-03-09 11:36:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743663002/1
3 years, 9 months ago (2017-03-09 11:36:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/954d9b943bff1c0ed834903a973f67ee1842b04a
3 years, 9 months ago (2017-03-09 11:37:01 UTC) #6
magjed_webrtc
3 years, 9 months ago (2017-03-09 12:37:53 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698