Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m

Issue 2743663002: Reland of Add unit tests for RTCMTLVideoView. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCMTLVideoView.h" 11 #import "WebRTC/RTCMTLVideoView.h"
12 12
13 #import <Metal/Metal.h> 13 #import <Metal/Metal.h>
14 #import <MetalKit/MetalKit.h> 14 #import <MetalKit/MetalKit.h>
15 15
16 #import "WebRTC/RTCLogging.h" 16 #import "WebRTC/RTCLogging.h"
17 #import "WebRTC/RTCVideoFrame.h" 17 #import "WebRTC/RTCVideoFrame.h"
18 18
19 #import "RTCMTLNV12Renderer.h" 19 #import "RTCMTLNV12Renderer.h"
20 20
21 // To avoid unreconized symbol linker errors, we're taking advantage of the objc runtime.
22 // Linking errors occur when compiling for architectures that don't support Meta l.
23 #define MTKViewClass NSClassFromString(@"MTKView")
24 #define RTCMTLNV12RendererClass NSClassFromString(@"RTCMTLNV12Renderer")
25
21 @interface RTCMTLVideoView () <MTKViewDelegate> 26 @interface RTCMTLVideoView () <MTKViewDelegate>
22 @property(nonatomic, strong) id<RTCMTLRenderer> renderer; 27 @property(nonatomic, strong) RTCMTLNV12Renderer *renderer;
23 @property(nonatomic, strong) MTKView *metalView; 28 @property(nonatomic, strong) MTKView *metalView;
24 @property(atomic, strong) RTCVideoFrame *videoFrame; 29 @property(atomic, strong) RTCVideoFrame *videoFrame;
25 @end 30 @end
26 31
27 @implementation RTCMTLVideoView { 32 @implementation RTCMTLVideoView
28 id<RTCMTLRenderer> _renderer;
29 }
30 33
31 @synthesize renderer = _renderer; 34 @synthesize renderer = _renderer;
32 @synthesize metalView = _metalView; 35 @synthesize metalView = _metalView;
33 @synthesize videoFrame = _videoFrame; 36 @synthesize videoFrame = _videoFrame;
34 37
35 - (instancetype)initWithFrame:(CGRect)frameRect { 38 - (instancetype)initWithFrame:(CGRect)frameRect {
36 self = [super initWithFrame:frameRect]; 39 self = [super initWithFrame:frameRect];
37 if (self) { 40 if (self) {
38 [self configure]; 41 [self configure];
39 } 42 }
(...skipping 11 matching lines...) Expand all
51 #pragma mark - Private 54 #pragma mark - Private
52 55
53 + (BOOL)isMetalAvailable { 56 + (BOOL)isMetalAvailable {
54 #if defined(RTC_SUPPORTS_METAL) 57 #if defined(RTC_SUPPORTS_METAL)
55 return YES; 58 return YES;
56 #else 59 #else
57 return NO; 60 return NO;
58 #endif 61 #endif
59 } 62 }
60 63
64 + (MTKView *)createMetalView:(CGRect)frame {
65 MTKView *view = [[MTKViewClass alloc] initWithFrame:frame];
66 return view;
67 }
68
69 + (RTCMTLNV12Renderer *)createMetalRenderer {
70 RTCMTLNV12Renderer *renderer = [[RTCMTLNV12RendererClass alloc] init];
71 return renderer;
72 }
73
61 - (void)configure { 74 - (void)configure {
62 if ([RTCMTLVideoView isMetalAvailable]) { 75 if (![RTCMTLVideoView isMetalAvailable]) {
63 _metalView = [[MTKView alloc] initWithFrame:self.bounds]; 76 RTCLog("Metal unavailable");
77 return;
78 }
79
80 _metalView = [RTCMTLVideoView createMetalView:self.bounds];
81 _renderer = [RTCMTLVideoView createMetalRenderer];
82
83 if ([self configureMetalRenderer]) {
84 [self configureMetalView];
85 } else {
86 _renderer = nil;
87 RTCLogError("Metal configuration falied.");
88 }
89 }
90
91 - (BOOL)configureMetalRenderer {
92 return [_renderer addRenderingDestination:_metalView];
93 }
94
95 - (void)configureMetalView {
96 if (_metalView) {
97 _metalView.delegate = self;
64 [self addSubview:_metalView]; 98 [self addSubview:_metalView];
65 _metalView.delegate = self;
66 _metalView.contentMode = UIViewContentModeScaleAspectFit; 99 _metalView.contentMode = UIViewContentModeScaleAspectFit;
67 _metalView.translatesAutoresizingMaskIntoConstraints = NO; 100 _metalView.translatesAutoresizingMaskIntoConstraints = NO;
68 UILayoutGuide *margins = self.layoutMarginsGuide; 101 UILayoutGuide *margins = self.layoutMarginsGuide;
69 [_metalView.topAnchor constraintEqualToAnchor:margins.topAnchor].active = YE S; 102 [_metalView.topAnchor constraintEqualToAnchor:margins.topAnchor].active = YE S;
70 [_metalView.bottomAnchor constraintEqualToAnchor:margins.bottomAnchor].activ e = YES; 103 [_metalView.bottomAnchor constraintEqualToAnchor:margins.bottomAnchor].activ e = YES;
71 [_metalView.leftAnchor constraintEqualToAnchor:margins.leftAnchor].active = YES; 104 [_metalView.leftAnchor constraintEqualToAnchor:margins.leftAnchor].active = YES;
72 [_metalView.rightAnchor constraintEqualToAnchor:margins.rightAnchor].active = YES; 105 [_metalView.rightAnchor constraintEqualToAnchor:margins.rightAnchor].active = YES;
73
74 _renderer = [[RTCMTLNV12Renderer alloc] init];
75 if (![(RTCMTLNV12Renderer *)_renderer addRenderingDestination:_metalView]) {
76 _renderer = nil;
77 };
78 } else {
79 RTCLogError("Metal configuration falied.");
80 } 106 }
81 } 107 }
108
82 #pragma mark - MTKViewDelegate methods 109 #pragma mark - MTKViewDelegate methods
83 110
84 - (void)drawInMTKView:(nonnull MTKView *)view { 111 - (void)drawInMTKView:(nonnull MTKView *)view {
85 NSAssert(view == self.metalView, @"Receiving draw callbacks from foreign insta nce."); 112 NSAssert(view == self.metalView, @"Receiving draw callbacks from foreign insta nce.");
86 [_renderer drawFrame:self.videoFrame]; 113 [self.renderer drawFrame:self.videoFrame];
87 } 114 }
88 115
89 - (void)mtkView:(MTKView *)view drawableSizeWillChange:(CGSize)size { 116 - (void)mtkView:(MTKView *)view drawableSizeWillChange:(CGSize)size {
90 } 117 }
91 118
92 #pragma mark - RTCVideoRenderer 119 #pragma mark - RTCVideoRenderer
93 120
94 - (void)setSize:(CGSize)size { 121 - (void)setSize:(CGSize)size {
95 _metalView.drawableSize = size; 122 self.metalView.drawableSize = size;
96 [_metalView draw]; 123 [self.metalView draw];
97 } 124 }
98 125
99 - (void)renderFrame:(nullable RTCVideoFrame *)frame { 126 - (void)renderFrame:(nullable RTCVideoFrame *)frame {
100 if (frame == nil) { 127 if (frame == nil) {
101 RTCLogInfo(@"Incoming frame is nil. Exiting render callback."); 128 RTCLogInfo(@"Incoming frame is nil. Exiting render callback.");
102 return; 129 return;
103 } 130 }
104 self.videoFrame = frame; 131 self.videoFrame = frame;
105 } 132 }
106 133
107 @end 134 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698