Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2733953006: Revert of Add unit tests for RTCMTLVideoView. (Closed)

Created:
3 years, 9 months ago by kthelgason
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add unit tests for RTCMTLVideoView. (patchset #6 id:100001 of https://codereview.webrtc.org/2723903003/ ) Reason for revert: This CL depends on a reverted CL. Original issue's description: > Add unit tests for RTCMTLVideoView. > > To properly test the functionality, following changes were needed > - Make RTCMTLVideoView compiliable for all cpu architectures not just arm64. > This is needed so that the test can run on any device and on simulator as well. > - Refactor RTCMTLVideoView to have mockable class methods. > The unittest class, RTCMTLVideoViewTests was designed to provide easy transition > to XCTest when the time comes for that. > To transition to XCTest it would suffice to inherit from XCTestCase and remove > the gtest methods. > > BUG=webrtc:7079 > > Review-Url: https://codereview.webrtc.org/2723903003 > Cr-Commit-Position: refs/heads/master@{#17014} > Committed: https://chromium.googlesource.com/external/webrtc/+/0ebe0199acd1070f17ca2abc5bc22fdd8b0861ca TBR=magjed@webrtc.org,denicija@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7079 Review-Url: https://codereview.webrtc.org/2733953006 Cr-Commit-Position: refs/heads/master@{#17118} Committed: https://chromium.googlesource.com/external/webrtc/+/96d91524fa66b9a2e4f9fbbbc9c5e5149021a3f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -228 lines) Patch
M webrtc/sdk/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h View 2 chunks +7 lines, -9 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m View 4 chunks +17 lines, -44 lines 0 comments Download
D webrtc/sdk/objc/Framework/UnitTests/RTCMTLVideoViewTests.mm View 1 chunk +0 lines, -168 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kthelgason
Created Revert of Add unit tests for RTCMTLVideoView.
3 years, 9 months ago (2017-03-08 14:12:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2733953006/1
3 years, 9 months ago (2017-03-08 14:12:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/96d91524fa66b9a2e4f9fbbbc9c5e5149021a3f0
3 years, 9 months ago (2017-03-08 14:33:56 UTC) #6
kthelgason
3 years, 9 months ago (2017-03-09 11:36:48 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2743663002/ by kthelgason@webrtc.org.

The reason for reverting is: Dependant CL has been relanded.

Powered by Google App Engine
This is Rietveld 408576698