Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2736483002: Enable and remove 2 tests in WebRtcVideoChannel2Test (Closed)

Created:
3 years, 9 months ago by Zach Stein
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRtcVideoChannel2Test::SetRecvCodecsAcceptsMultipleVideoCodecs passes now. WebRtcVideoChannel2Test::SetRecvCodecsSetsFecForAllVideoCodecs was never fully implemented and hasn't been touched in over a year. BUG=NONE Review-Url: https://codereview.webrtc.org/2736483002 Cr-Commit-Position: refs/heads/master@{#17075} Committed: https://chromium.googlesource.com/external/webrtc/+/d5a2d9ad0cbfa38f58582c19920c24733059d2a2

Patch Set 1 #

Patch Set 2 : Removing an unfinished test that hasn't been touched for at least a year. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Zach Stein
3 years, 9 months ago (2017-03-04 07:01:49 UTC) #3
Taylor Brandstetter
lgtm For something small like this, you can use BUG=None. Also, try to fit the ...
3 years, 9 months ago (2017-03-06 00:36:06 UTC) #4
Zach Stein
Could you take a quick look pbos? Thanks!
3 years, 9 months ago (2017-03-06 19:30:08 UTC) #7
pbos-webrtc
lgtm, but please update the CL title + description to say which test you're disabling. ...
3 years, 9 months ago (2017-03-06 19:32:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2736483002/20001
3 years, 9 months ago (2017-03-06 19:38:53 UTC) #11
pbos-webrtc
On 2017/03/06 19:38:53, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 9 months ago (2017-03-06 19:41:36 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:09:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d5a2d9ad0cbfa38f58582c199...

Powered by Google App Engine
This is Rietveld 408576698