Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 2736483002: Enable and remove 2 tests in WebRtcVideoChannel2Test (Closed)
Patch Set: Removing an unfinished test that hasn't been touched for at least a year. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 2955 matching lines...) Expand 10 before | Expand all | Expand 10 after
2966 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type); 2966 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
2967 } 2967 }
2968 2968
2969 TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsRejectUnsupportedCodec) { 2969 TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsRejectUnsupportedCodec) {
2970 cricket::VideoRecvParameters parameters; 2970 cricket::VideoRecvParameters parameters;
2971 parameters.codecs.push_back(GetEngineCodec("VP8")); 2971 parameters.codecs.push_back(GetEngineCodec("VP8"));
2972 parameters.codecs.push_back(VideoCodec(101, "WTF3")); 2972 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
2973 EXPECT_FALSE(channel_->SetRecvParameters(parameters)); 2973 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
2974 } 2974 }
2975 2975
2976 // TODO(pbos): Enable VP9 through external codec support 2976 TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsAcceptsMultipleVideoCodecs) {
2977 TEST_F(WebRtcVideoChannel2Test,
2978 DISABLED_SetRecvCodecsAcceptsMultipleVideoCodecs) {
2979 cricket::VideoRecvParameters parameters; 2977 cricket::VideoRecvParameters parameters;
2980 parameters.codecs.push_back(GetEngineCodec("VP8")); 2978 parameters.codecs.push_back(GetEngineCodec("VP8"));
2981 parameters.codecs.push_back(GetEngineCodec("VP9")); 2979 parameters.codecs.push_back(GetEngineCodec("VP9"));
2982 EXPECT_TRUE(channel_->SetRecvParameters(parameters)); 2980 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
2983 } 2981 }
2984 2982
2985 TEST_F(WebRtcVideoChannel2Test,
2986 DISABLED_SetRecvCodecsSetsFecForAllVideoCodecs) {
2987 cricket::VideoRecvParameters parameters;
2988 parameters.codecs.push_back(GetEngineCodec("VP8"));
2989 parameters.codecs.push_back(GetEngineCodec("VP9"));
2990 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
2991 FAIL(); // TODO(pbos): Verify that the FEC parameters are set for all codecs.
2992 }
2993
2994 TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsWithoutFecDisablesFec) { 2983 TEST_F(WebRtcVideoChannel2Test, SetRecvCodecsWithoutFecDisablesFec) {
2995 cricket::VideoSendParameters send_parameters; 2984 cricket::VideoSendParameters send_parameters;
2996 send_parameters.codecs.push_back(GetEngineCodec("VP8")); 2985 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
2997 send_parameters.codecs.push_back(GetEngineCodec("red")); 2986 send_parameters.codecs.push_back(GetEngineCodec("red"));
2998 send_parameters.codecs.push_back(GetEngineCodec("ulpfec")); 2987 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
2999 ASSERT_TRUE(channel_->SetSendParameters(send_parameters)); 2988 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3000 2989
3001 FakeVideoReceiveStream* stream = AddRecvStream(); 2990 FakeVideoReceiveStream* stream = AddRecvStream();
3002 2991
3003 EXPECT_EQ(GetEngineCodec("ulpfec").id, 2992 EXPECT_EQ(GetEngineCodec("ulpfec").id,
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
4366 } 4355 }
4367 4356
4368 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsForSimulcastScreenshare) { 4357 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsForSimulcastScreenshare) {
4369 webrtc::test::ScopedFieldTrials override_field_trials_( 4358 webrtc::test::ScopedFieldTrials override_field_trials_(
4370 "WebRTC-SimulcastScreenshare/Enabled/"); 4359 "WebRTC-SimulcastScreenshare/Enabled/");
4371 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true, 4360 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
4372 true); 4361 true);
4373 } 4362 }
4374 4363
4375 } // namespace cricket 4364 } // namespace cricket
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698